lint(common): fix 'StaticFieldLeak'

* Fixes usage analytics by using the Application context
* Use `Application` where it's a false positive

Author: david-allison

AnkiDroid/src/main/java/com/ichi2/anki/analytics/AnkiDroidUsageAnalytics.kt

@@ -3,6 +3,7 @@
 
 package com.ichi2.anki.analytics
 
+import android.app.Application
 import android.content.Context
 import android.content.SharedPreferences
 import androidx.core.content.edit
@@ -53,7 +54,7 @@ object AnkiDroidUsageAnalytics {
      * be uninitialized in rare Android scenarios (e.g. BackupManager) and
      * analytics is a startup concern that must not crash.
      */
-    private lateinit var analyticsContext: Context
+    private lateinit var analyticsContext: Application
 
     private val serviceScope = CoroutineScope(Dispatchers.IO + SupervisorJob())
     private val clientId: String by lazy { getOrCreateClientId(analyticsContext) }
@@ -87,7 +88,7 @@ object AnkiDroidUsageAnalytics {
         private set
 
     fun initialize(context: Context) {
-        analyticsContext = context.applicationContext
+        analyticsContext = context.applicationContext as Application
 
         Timber.i("AnkiDroidUsageAnalytics:: initialize()")
 

AnkiDroid/src/main/java/com/ichi2/anki/navigation/AnkiDroidNavigator.kt

@@ -3,7 +3,6 @@
 package com.ichi2.anki.navigation
 
 import android.app.Application
-import android.content.Context
 import android.content.Intent
 import com.ichi2.anki.browser.toIntent
 import com.ichi2.anki.common.destinations.BrowserDestination
@@ -12,7 +11,7 @@ import com.ichi2.anki.common.destinations.Navigator
 
 /** AnkiDroid's [Navigator] implementation. */
 object AnkiDroidNavigator : Navigator {
-    private lateinit var navContext: Context
+    private lateinit var navContext: Application
 
     fun initialize(application: Application) {
         navContext = application

lint-release.xml

@@ -173,6 +173,7 @@
     <issue id="PackagedPrivateKey" severity="fatal" />
     <issue id="HardcodedDebugMode" severity="fatal" />
     <issue id="HandlerLeak" severity="fatal" />
+    <issue id="StaticFieldLeak" severity="fatal" />
     <issue id="ServiceCast" severity="fatal" />
     <issue id="CutPasteId" severity="fatal" />
     <issue id="WrongCall" severity="fatal" />
@@ -351,7 +352,6 @@
     <issue id="LabelFor" severity="ignore" />
     <issue id="InconsistentLayout" severity="ignore" />
     <issue id="InflateParams" severity="ignore" />
-    <issue id="StaticFieldLeak" severity="ignore" />
     <issue id="DefaultLocale" severity="error" />
     <issue id="LocaleFolder" severity="ignore" />
     <issue id="LocaleRootUsage" severity="error" />