feat: launchCatching - handle StorageNotConfiguredException

Assisted-by: Claude Fable 5

Author: david-allison

AnkiDroid/src/main/java/com/ichi2/anki/CoroutineHelpers.kt

@@ -34,10 +34,12 @@ import com.ichi2.anki.common.destinations.DeckOptionsDestination
 import com.ichi2.anki.dialogs.DatabaseErrorDialog
 import com.ichi2.anki.dialogs.DatabaseErrorDialog.DatabaseErrorDialogType
 import com.ichi2.anki.exception.StorageAccessException
+import com.ichi2.anki.exception.StorageNotConfiguredException
 import com.ichi2.anki.libanki.exception.InvalidSearchException
 import com.ichi2.anki.pages.fromCurrentDeck
 import com.ichi2.anki.pages.toIntent
 import com.ichi2.anki.snackbar.showSnackbar
+import com.ichi2.anki.startup.redirectToMainEntryPoint
 import com.ichi2.anki.ui.internationalization.sentenceCase
 import com.ichi2.anki.utils.openUrl
 import com.ichi2.utils.create
@@ -190,6 +192,12 @@ suspend fun <T> FragmentActivity.runCatching(
                 Timber.w(exc, errorMessage)
                 exc.localizedMessage?.let { showSnackbar(it) }
             }
+            is StorageNotConfiguredException -> {
+                // expected before first-run setup completes: no crash report
+                // edge case when 'ensureStorageIsReady' was insufficient
+                Timber.w(exc, errorMessage)
+                if (!isFinishing) redirectToMainEntryPoint()
+            }
             is BackendNetworkException, is BackendSyncException, is StorageAccessException, is BackendCardTypeException -> {
                 // these exceptions do not generate worthwhile crash reports
                 Timber.i("Showing error dialog but not sending a crash report.")

AnkiDroid/src/test/java/com/ichi2/anki/CoroutineHelpersRobolectricTest.kt

@@ -0,0 +1,35 @@
+// SPDX-License-Identifier: GPL-3.0-or-later
+
+package com.ichi2.anki
+
+import androidx.fragment.app.FragmentActivity
+import androidx.test.ext.junit.runners.AndroidJUnit4
+import com.ichi2.anki.exception.StorageNotConfiguredException
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.robolectric.Robolectric
+import org.robolectric.Shadows.shadowOf
+import kotlin.test.assertEquals
+import kotlin.test.assertNotNull
+import kotlin.test.assertTrue
+
+@RunWith(AndroidJUnit4::class)
+class CoroutineHelpersRobolectricTest : RobolectricTest() {
+    /**
+     * A [StorageNotConfiguredException] escaping a coroutine means an activity raced or
+     * outlived its [ensureStorageIsReady][com.ichi2.anki.startup.ensureStorageIsReady] check:
+     * the user should be sent to the main entry point, which handles storage setup.
+     */
+    @Test
+    fun `launchCatchingTask redirects to main entry point when storage is not configured`() {
+        val activity = Robolectric.buildActivity(FragmentActivity::class.java).create().get()
+
+        activity.launchCatchingTask { throw StorageNotConfiguredException() }
+        advanceRobolectricLooper()
+
+        assertTrue(activity.isFinishing, "activity should finish")
+        val redirect = shadowOf(activity).nextStartedActivity
+        assertNotNull(redirect, "the main entry point should be opened")
+        assertEquals(IntentHandler::class.qualifiedName, redirect.component?.className)
+    }
+}