[BUG]: We don't crash on some unhandled exceptions

[david-allison]

BackendNetworkException does not cause a crash if unhandled due to:

Anki-Android/AnkiDroid/src/main/java/com/ichi2/anki/servicelayer/ThrowableFilterService.kt

Lines 39 to 43 in 5904c8a

	if (shouldDiscardThrowable(throwable)) {
	Timber.i("discarding throwable")
	return@FilteringExceptionHandler
	}
	originalUncaughtExceptionHandler?.uncaughtException(thread, throwable)

Originally posted by @david-allison in #19627

---

• 333ef64
• Block reports sent to ACRA #17402
• Special case and remove from ACRA: "Syncing failed, because your email address needs to be (re)confirmed." #17392

[david-allison]

If this is an unhandled exception, we want this to appear in ACRA, but without the PII

I believe that this would be acceptable if we only include:

• Exception class name
• Exception stack trace
• Exception cause, recursively with the above filtering

Needs discussion before implementation

[vinayakkumargupta]

@david-allison we should not discard uncaught exception , we can forward a sanitized version of throwable to original uncaught exceptional handler
Sanitized throwable be like
Exception class name
Exception stack trace
Exception cause, recursively with the above filtering

So this way cash will be visible to ACRA no to PII

Can make a Sanitized throwable class if you want

[david-allison]

Could you check in the Discord on this one, cheers!

[vinayakkumargupta]

where in Discord @david-allison