CI test for 16kb and non-16kb page alignment by Haz3-jolt · Pull Request #18248 · ankidroid/Anki-Android

Haz3-jolt · 2025-04-24T16:07:08Z

Purpose / Description

Updates GitHub workflow matrix to extend to 16kb page alignment.

Fixes

Fixes CI should test 16kb and non-16kb page alignment in libraries, packaging, and emulator #16917

Approach

Attempts to verify the APK with 16KB page alignment
First tries with build-tools v35.0.0, then falls back to v34.0.0 if needed
Provides clear success/failure messages

How Has This Been Tested?

Passes CI on fork

Learning (optional, can help others)

Refered to 16KB page alignment docs

Checklist

Please, go through these checks before submitting the PR.

You have a descriptive commit message with a short title (first line, max 50 chars).
You have commented your code, particularly in hard-to-understand areas
You have performed a self-review of your own code
UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
UI Changes: You have tested your change using the Google Accessibility Scanner

Arthur-Milchior

I don't understand enough to tell anything else than that we should add a note about the original author of the new file, sorry

Haz3-jolt · 2025-05-01T16:56:22Z

@mikehardy
I tried to verify page size with:

      - name: Verify Page Size
        if: matrix.target == 'google_apis_ps16k'
        run: |
          PAGE_SIZE=$(adb shell getconf PAGE_SIZE)
          echo "Page size: $PAGE_SIZE"
          if [ "$PAGE_SIZE" != "16384" ]; then
            echo "Error: Expected page size of 16384, got $PAGE_SIZE"
            exit 1
          fi

But when I noticed it wasn't running in the tests, I realised we can't run adb shell getconf PAGE_SIZE, without an emulator. Is it okay to not include it? I've tried adding it to the Emulator script in here. But It wasn't working.

Is there some other way to test it?

david-allison

Executes a Google script. Looks fine to me

mikehardy

Sorry this sat so long when you were trying to close an issue I logged myself!

I think all of the ideas and the main work here are great. My comments need to be addressed but I think (hope ?) they're all easy modifications on your core work here, just to future proof it

mikehardy

closer still - but did realize that we're not actually executing tests against the google_apis_ps16k emulator target

mikehardy · 2025-06-25T16:24:04Z

+            iteration: 0
+          - api-level: 35
+            arch: x86_64
+            target: google_apis


Fantastic - approved, pending upstream PR merge+release and this change here

Suggested change

target: google_apis

target: google_apis_ps16k

Pending fix: allow google_apis_ps16k as a valid target ReactiveCircus/android-emulator-runner#440

Yep I have amended the commit already, waiting for the release to do a force push!

had a review comment on that PR I just had time to address now, hopefully will release soon - maintainer there is collaborating fine and that change is needed of course

Hasn't been released yet, but temporarily depending on this commit hash for the android-emulator-runner package should work, the PR is merged now ReactiveCircus/android-emulator-runner@66283c0

mikehardy · 2025-11-25T19:50:20Z

Upstream emulator runner finally released with my PR, should be good to go

mikehardy · 2025-11-25T20:47:54Z

Dangit. My PR was apparently inadequate, the emulator type of 16kb is now going through but there is some missing piece translating that to the create create avd command

  /usr/bin/sh -c \echo no | avdmanager create avd --force -n test --abi 'google_apis_ps16k/x86_64' --package 'system-images;android-36;google_apis_ps16k;x86_64'  --sdcard '100M'
  Loading local repository...                                                     
  [=========                              ] 25% Loading local repository...       
  [=========                              ] 25% Fetch remote repository...        
  [=======================================] 100% Fetch remote repository...       
  Error: Invalid --tag google_apis_ps16k for the selected package. Valid tags are:
  page_size_16kb

I'm on it

mikehardy · 2025-11-25T21:42:13Z

This thing just won't get fixed, sigh, now this PR is block

fix: remove problematic / unneeded --abi option in avd creation ReactiveCircus/android-emulator-runner#456

Haz3-jolt · 2025-11-27T15:29:43Z

This thing just won't get fixed, sigh, now this PR is block

* [fix: remove problematic / unneeded `--abi` option in avd creation ReactiveCircus/android-emulator-runner#456](https://github.com/ReactiveCircus/android-emulator-runner/pull/456)

CI work being finicky as usual, I think another month or so till this is unblocked

david-allison · 2026-04-23T12:50:22Z

seeing if this will go through now. Rebased on main

Haz3-jolt · 2026-04-23T13:48:32Z

seeing if this will go through now. Rebased on main

The runner image hasn't had a new release :(

david-allison · 2026-04-23T13:50:30Z

@Haz3-jolt
Looks recent: https://github.com/ReactiveCircus/android-emulator-runner/releases/tag/v2.37.0

Mike's changes are in: https://github.com/ReactiveCircus/android-emulator-runner/releases/tag/v2.36.0

david-allison · 2026-04-23T16:36:46Z

com.ichi2.anki.DeckPickerTest > checkIfStudyOptionsIsDisplayedOnTablet[emulator-5554 - 16] SKIPPED
ERROR | bad color buffer handle 561
emulator-5554 - 16 Tests 2/319 completed. (1 skipped) (0 failed)

com.ichi2.anki.DeckPickerTest > checkIfClickOnCountsLayoutOpensStudyOptionsOnMobile[emulator-5554 - 16] FAILED

Arthur-Milchior reviewed Apr 28, 2025

View reviewed changes

Comment thread .github/check_elf_alignment.sh

Haz3-jolt force-pushed the pages branch from 0314111 to e386237 Compare April 28, 2025 13:50

david-allison approved these changes May 3, 2025

View reviewed changes

BrayanDSO added the Needs Second Approval Has one approval, one more approval to merge label May 3, 2025

mikehardy requested changes Jun 3, 2025

View reviewed changes

Comment thread .github/workflows/tests_emulator.yml Outdated

Comment thread .github/workflows/tests_emulator.yml Outdated

Comment thread .github/workflows/tests_emulator.yml Outdated

mikehardy added the Needs Author Reply Waiting for a reply from the original author label Jun 3, 2025

Haz3-jolt force-pushed the pages branch from 867d9f4 to acaa74f Compare June 4, 2025 08:37

Haz3-jolt requested a review from mikehardy June 4, 2025 12:21

Haz3-jolt added the CI label Jun 5, 2025

Haz3-jolt force-pushed the pages branch 2 times, most recently from dc08ce9 to c44c1cd Compare June 5, 2025 12:55

This comment was marked as resolved.

Sign in to view

Haz3-jolt marked this pull request as draft June 5, 2025 16:20

Haz3-jolt removed the Needs Author Reply Waiting for a reply from the original author label Jun 12, 2025

Haz3-jolt force-pushed the pages branch 2 times, most recently from efccd3e to d46e53c Compare June 25, 2025 14:33

mikehardy requested changes Jun 25, 2025

View reviewed changes

Comment thread .github/workflows/tests_emulator.yml Outdated

Comment thread .github/workflows/tests_emulator.yml Outdated

Comment thread .github/workflows/tests_emulator.yml Outdated

mikehardy added the Needs Author Reply Waiting for a reply from the original author label Jun 25, 2025

Haz3-jolt force-pushed the pages branch 2 times, most recently from 727da2f to 9dacc54 Compare June 25, 2025 15:31

Haz3-jolt removed the Needs Author Reply Waiting for a reply from the original author label Jun 25, 2025

mikehardy approved these changes Jun 25, 2025

View reviewed changes

Haz3-jolt marked this pull request as ready for review July 2, 2025 20:09

github-actions Bot added Has Conflicts labels Jul 14, 2025

Haz3-jolt force-pushed the pages branch from 9dacc54 to 393ddea Compare July 21, 2025 14:38

Haz3-jolt removed the Has Conflicts label Jul 21, 2025

mikehardy force-pushed the pages branch 3 times, most recently from 2ba9a2b to 5e1e1d1 Compare November 6, 2025 23:12

mikehardy removed the Blocked by dependency Currently blocked by some other dependent / related change label Nov 6, 2025

mikehardy mentioned this pull request Nov 6, 2025

CI should test 16kb and non-16kb page alignment in libraries, packaging, and emulator #16917

Open

mikehardy force-pushed the pages branch from 5e1e1d1 to 2a56800 Compare November 25, 2025 19:49

mikehardy added the Blocked by dependency Currently blocked by some other dependent / related change label Nov 25, 2025

Haz3-jolt added 2 commits April 23, 2026 13:49

Add ELF alignment script from google

7d0a9e5

CI test for 16kb and non-16kb page alignment

6e5bd05

david-allison force-pushed the pages branch from 2a56800 to 6e5bd05 Compare April 23, 2026 12:49

Uh oh!

Conversation

Haz3-jolt commented Apr 24, 2025

Purpose / Description

Fixes

Approach

How Has This Been Tested?

Learning (optional, can help others)

Checklist

Uh oh!

Arthur-Milchior left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Haz3-jolt commented May 1, 2025

Uh oh!

david-allison left a comment

Choose a reason for hiding this comment

Uh oh!

mikehardy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

mikehardy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mikehardy Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

Haz3-jolt Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikehardy Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

mikehardy Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

mikehardy commented Nov 25, 2025

Uh oh!

mikehardy commented Nov 25, 2025

Uh oh!

mikehardy commented Nov 25, 2025

Uh oh!

Haz3-jolt commented Nov 27, 2025

Uh oh!

david-allison commented Apr 23, 2026

Uh oh!

Haz3-jolt commented Apr 23, 2026

Uh oh!

david-allison commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

david-allison commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Haz3-jolt Jun 25, 2025 •

edited

Loading

david-allison commented Apr 23, 2026 •

edited

Loading