chore: begin view binding migration#19324
Merged
lukstbit merged 2 commits intoankidroid:mainfrom Oct 12, 2025
Merged
Conversation
Issue 11116
BrayanDSO
approved these changes
Oct 12, 2025
Member
BrayanDSO
left a comment
There was a problem hiding this comment.
Lint is failing. Rest looks good
https://github.com/androidbroadcast/ViewBindingPropertyDelegate/ Simplifies the API for View Bindings Chosen as it has a simple, non-reflection-based API There is a line of duplication of `R.layout` references/ViewBinding caused by the lack of reflection Issue 11116
0e5c091 to
a998115
Compare
lukstbit
approved these changes
Oct 12, 2025
Member
lukstbit
left a comment
There was a problem hiding this comment.
LGTM.
Lint was failing due to a missing copyright header in VbpUtils.kt, I added that to get things moving. I'll also add the license entry to the wiki
diff --git a/AnkiDroid/src/main/java/dev/androidbroadcast/vbpd/internal/VbpdUtils.kt b/AnkiDroid/src/main/java/dev/androidbroadcast/vbpd/internal/VbpdUtils.kt
index f689d4d41f..5a9cb2c760 100644
--- a/AnkiDroid/src/main/java/dev/androidbroadcast/vbpd/internal/VbpdUtils.kt
+++ b/AnkiDroid/src/main/java/dev/androidbroadcast/vbpd/internal/VbpdUtils.kt
@@ -1,4 +1,20 @@
/*
+ * Copyright (c) 2025 David Allison <davidallisongithub@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify it under
+ * the terms of the GNU General Public License as published by the Free Software
+ * Foundation; either version 3 of the License, or (at your option) any later
+ * version.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT ANY
+ * WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A
+ * PARTICULAR PURPOSE. See the GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ * This file incorporates code under the following license:
+ *
* Copyright 2020-2025 Kirill Rozov
*
* Licensed under the Apache License, Version 2.0 (the "License");
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
This begins AnkiDroid's transition to ViewBindings.
This has mostly been completed in the following pull request, this code exists so we can perform an architecture review of the dependency, and so I can start splitting the linked PR into reviewable chunks
Fixes
Approach
How Has This Been Tested?
Non-functional change
Learning (optional, can help others)
Checklist
Licenses
vbdp)Maintainers: