[Multiple-Profile]feat: allow profile deletion by criticalAY · Pull Request #20658 · ankidroid/Anki-Android

criticalAY · 2026-04-05T16:07:59Z

Purpose / Description

Allow profile deletion -> Adding a method in PrpfileManager to allow deletion or profiles except the active

Fixes

Fixes part of Add support for profiles #18117

Approach

See commit

How Has This Been Tested?

Unit test

Learning (optional, can help others)

NA

Checklist

Please, go through these checks before submitting the PR.

You have a descriptive commit message with a short title (first line, max 50 chars).
You have commented your code, particularly in hard-to-understand areas
You have performed a self-review of your own code
UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
UI Changes: You have tested your change using the Google Accessibility Scanner

david-allison · 2026-04-05T16:51:57Z

Why is this a bulk operation?

criticalAY · 2026-04-05T16:52:30Z

What if user wants to delete 3-4 profiles in one go?

david-allison · 2026-04-05T17:00:08Z

I doubt that's a realistic use case, and upstream doesn't support it. (Maybe when we have analytics back 😉).

I might be one of the few people where this would make sense (I might have 50 profiles). At this point, I don't know what each profile contains, so I'd still want to go one-by-one

criticalAY · 2026-04-05T17:01:43Z

I actually did it for one profile at a time but I am okay with reverting to my original idea.

david-allison · 2026-04-05T17:06:11Z

For what it's worth, I disabled multi-delete for tags - mixing filtering and deleting felt dangerous from a UI perspective

As deleting a profile is so risky, you might want explicit confirmation (type the profile name to delete it). Does this delete backups?

criticalAY · 2026-04-09T04:59:23Z

We can do that, but is that related to this PR?

david-allison

Much better!

david-allison · 2026-04-09T05:28:57Z

+            "Cannot delete the currently active profile (${profileId.value}). Switch first."
+        }
+
+        profileRegistry.removeProfile(profileId)


Think about the ordering here. Assume the user can kill the operation at any time. Is it better to have the files left on disk?

david-allison · 2026-04-09T05:36:19Z

I think a doc in /docs/AnkiDroid would be useful, just with the directory structure which was agreed upon (and the names of the concepts: profile directory etc...)

This would be a useful reference now to be sure all directories are handled and deleted

david-allison

My comment with a doc on the profile data/directory structure stands, it is ideal to have a single source of truth for the directories under a profile, and the global directories, so we can determine what should be deleted when a profile is deleted, to ensure there's no dangling files/directories

david-allison · 2026-04-15T12:43:35Z

+     * Scope of deletion is limited to the profile's private-storage
+     * directory (under `/storage/emulated/0/Android/data/com.ichi2.anki/files/...`):
+     * the collection database and any files the app writes inside that
+     * directory. Backups live in a separate, user-accessible location
+     * (`/storage/emulated/0/AnkiDroid/backups`) and are **not** touched
+     * here — their lifecycle is managed by the collection-folder guard
+     * elsewhere in the app. Deletion is irreversible.


Backups live in a separate, user-accessible location (/storage/emulated/0/AnkiDroid/backups)

No they don't. They're under /storage/emulated/0/Android/data/com.ichi2.anki/files/ on a Google Play build

Support for choosing a custom backup location #15034

Ahh thanks, i found a bug thanks to this comment, default profile would have wiped all profiles, I have fixed that now added a test

david-allison · 2026-04-15T14:34:39Z

+     * BACKUPS & PRIVACY:
+     * On Google Play builds, backups are stored within the app's internal scoped storage


On all builds. Backups live in the profile-specific directory

david-allison · 2026-04-15T14:34:59Z

+    /**
+     * Permanently deletes a profile, removing its on-disk data and registry entry.
+     *
+     * SCOPE OF DELETION:


These headers are unusual, no need for them

Introduce deleteProfile() for removing a single user profile. Deletion removes both the registry entry (SharedPreferences) and the on-disk data directory. The only guard is: the currently active profile cannot be deleted, all other profiles including default are deletable.

david-allison · 2026-04-18T10:04:23Z

+            if (appDataRoot != null) {
+                val sharedPrefsDir = File(appDataRoot, "shared_prefs")
+                if (sharedPrefsDir.exists() && sharedPrefsDir.isDirectory) {
+                    val prefix = "profile_${profileId.value}_"
+                    sharedPrefsDir.listFiles()?.forEach { file ->
+                        if (file.name.startsWith(prefix)) {
+                            file.delete()
+                        }
+                    }
+                }


extract to a method - allows for early returns to simplify logic

david-allison · 2026-04-18T10:08:28Z

+     * - External Storage (/storage/emulated/0/Android/data/.../files): Deletes the
+     *   AnkiDroid collection directory, media, and backups for this profile.
+     */
+    fun deleteProfile(profileId: ProfileId) {


If a user can select an arbitrary directory: do we want to be more careful?

david-allison · 2026-04-18T10:10:03Z

+        val externalFilesDir = appContext.getExternalFilesDir(null)
+        if (externalFilesDir != null) {
+            val collectionFolderName = if (profileId.isDefault()) "AnkiDroid" else profileId.value
+            val collectionDir = File(externalFilesDir, collectionFolderName)
+
+            if (collectionDir.exists()) {
+                collectionDir.deleteRecursively()
+            }
+        }


This is the first time AnkiDroid allows deleting a folder like this.

What if a user puts AnkiDroid in /Pictures/ - we likely want to selectively delete the known AnkiDroid files, rather than everything

github-actions bot added the Needs Review label Apr 5, 2026

This comment was marked as resolved.

Sign in to view

criticalAY force-pushed the mp/del-profiles branch from 4df4d66 to 7e2d1e0 Compare April 5, 2026 17:41

This comment was marked as off-topic.

Sign in to view

david-allison reviewed Apr 9, 2026

View reviewed changes

Comment thread AnkiDroid/src/main/java/com/ichi2/anki/multiprofile/ProfileManager.kt Outdated

criticalAY force-pushed the mp/del-profiles branch from 7e2d1e0 to 30a1d3f Compare April 9, 2026 08:30

david-allison requested changes Apr 15, 2026

View reviewed changes

criticalAY force-pushed the mp/del-profiles branch from 30a1d3f to ef4d854 Compare April 15, 2026 14:02

criticalAY requested a review from david-allison April 15, 2026 14:04

david-allison reviewed Apr 15, 2026

View reviewed changes

Comment thread AnkiDroid/src/main/java/com/ichi2/anki/multiprofile/ProfileManager.kt Outdated

criticalAY force-pushed the mp/del-profiles branch from ef4d854 to 59d9ea9 Compare April 15, 2026 14:06

criticalAY requested a review from david-allison April 15, 2026 14:06

david-allison reviewed Apr 15, 2026

View reviewed changes

criticalAY force-pushed the mp/del-profiles branch from 59d9ea9 to ebe616e Compare April 15, 2026 17:25

david-allison requested changes Apr 18, 2026

View reviewed changes

github-actions bot added the Has Conflicts label Apr 19, 2026

		* BACKUPS & PRIVACY:
		* On Google Play builds, backups are stored within the app's internal scoped storage

Uh oh!

Conversation

criticalAY commented Apr 5, 2026

Purpose / Description

Fixes

Approach

How Has This Been Tested?

Learning (optional, can help others)

Checklist

Uh oh!

david-allison commented Apr 5, 2026

Uh oh!

criticalAY commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

david-allison commented Apr 5, 2026

Uh oh!

criticalAY commented Apr 5, 2026

Uh oh!

david-allison commented Apr 5, 2026

Uh oh!

This comment was marked as resolved.

This comment was marked as off-topic.

criticalAY commented Apr 9, 2026

Uh oh!

david-allison left a comment

Choose a reason for hiding this comment

Uh oh!

david-allison Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

david-allison commented Apr 9, 2026

Uh oh!

Uh oh!

david-allison left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

david-allison Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

criticalAY Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

david-allison Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

david-allison Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

david-allison Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

david-allison Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

david-allison Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

criticalAY commented Apr 5, 2026 •

edited

Loading

david-allison left a comment •

edited

Loading

david-allison Apr 15, 2026 •

edited

Loading