Skip to content

refactor(deck-picker) extract optionsMenuState to ViewModel#20679

Merged
lukstbit merged 1 commit intoankidroid:mainfrom
david-allison:deckpicker-next
Apr 17, 2026
Merged

refactor(deck-picker) extract optionsMenuState to ViewModel#20679
lukstbit merged 1 commit intoankidroid:mainfrom
david-allison:deckpicker-next

Conversation

@david-allison
Copy link
Copy Markdown
Member

Note

Assisted by Claude Opus 4.6 - suggestion, about half the refactoring

How Has This Been Tested?

Briefly opened the screen, API 33 emulator

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison changed the title refactor(deck-picker) extract optionsMenuState refactor(deck-picker) extract optionsMenuState to ViewModel Apr 7, 2026
@david-allison david-allison force-pushed the deckpicker-next branch 2 times, most recently from 192e043 to 7faad5f Compare April 7, 2026 00:35
@david-allison david-allison marked this pull request as ready for review April 7, 2026 00:42
@criticalAY criticalAY added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Apr 8, 2026
Copy link
Copy Markdown
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a partial refactoring? Feels like there should be more.

Comment thread AnkiDroid/src/main/java/com/ichi2/anki/deckpicker/DeckPickerViewModel.kt Outdated
Comment thread AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt
@david-allison
Copy link
Copy Markdown
Member Author

I was going for a stream of small, partial refactorings on this class to move to the ViewModel, would you prefer larger structural changes?

@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Apr 11, 2026
+ combine with flowOfUndoUpdated

Assisted by Claude Opus 4.6 - about half the refactoring
@david-allison david-allison requested a review from lukstbit April 12, 2026 00:04
@david-allison david-allison removed the Needs Author Reply Waiting for a reply from the original author label Apr 12, 2026
Copy link
Copy Markdown
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

I was going for a stream of small, partial refactorings on this class to move to the ViewModel, would you prefer larger structural changes?

Smaller.

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Apr 17, 2026
@lukstbit lukstbit added this pull request to the merge queue Apr 17, 2026
Merged via the queue into ankidroid:main with commit 51ab6d6 Apr 17, 2026
15 checks passed
@github-actions github-actions Bot added this to the 2.24 release milestone Apr 17, 2026
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants