refactor(deck-picker) extract optionsMenuState to ViewModel#20679
Merged
lukstbit merged 1 commit intoankidroid:mainfrom Apr 17, 2026
Merged
refactor(deck-picker) extract optionsMenuState to ViewModel#20679lukstbit merged 1 commit intoankidroid:mainfrom
lukstbit merged 1 commit intoankidroid:mainfrom
Conversation
192e043 to
7faad5f
Compare
criticalAY
approved these changes
Apr 8, 2026
lukstbit
reviewed
Apr 11, 2026
Member
lukstbit
left a comment
There was a problem hiding this comment.
Is this a partial refactoring? Feels like there should be more.
Member
Author
|
I was going for a stream of small, partial refactorings on this class to move to the ViewModel, would you prefer larger structural changes? |
7faad5f to
4dc6c05
Compare
+ combine with flowOfUndoUpdated Assisted by Claude Opus 4.6 - about half the refactoring
4dc6c05 to
6d82080
Compare
lukstbit
approved these changes
Apr 17, 2026
Member
lukstbit
left a comment
There was a problem hiding this comment.
Ok.
I was going for a stream of small, partial refactorings on this class to move to the ViewModel, would you prefer larger structural changes?
Smaller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted by Claude Opus 4.6 - suggestion, about half the refactoring
How Has This Been Tested?
Briefly opened the screen, API 33 emulator
Checklist