refactor(deck-picker): introduce UiEvent#20683
Open
david-allison wants to merge 3 commits intoankidroid:mainfrom
Open
refactor(deck-picker): introduce UiEvent#20683david-allison wants to merge 3 commits intoankidroid:mainfrom
david-allison wants to merge 3 commits intoankidroid:mainfrom
Conversation
david-allison
force-pushed
the
deck=picker-view-model
branch
from
2891b8f to
5028a84
Compare
`setup-gradle@v6` now hard-errors when it can't find files to build a hash key. Previously it had nothing to hash, now it hashes the selected PR Fixes 20779 Assisted-by: Claude Opus 4.7 - diagnostics
A common pattern in MVI (and some of Compose) is to encapsulate all one-shot side-effects into a wrapper interface. This is implemented via a Channel, enforcing correct one-shot and buffering behavior This pattern allows: * Removal of 'StateFlow-related' bugs * Removal of 'val' flows * Simple 'Result' classes * Fewer methods handling 'Unit' in the DeckPicker The test was updated as it should not have been accessing the flows of the ViewModel Assisted-by: Claude Opus 4.6
Now we have UiEvent, we have no need for these classes Assisted-by: Claude Opus 4.6
david-allison
force-pushed
the
deck=picker-view-model
branch
from
5028a84 to
36d7dbb
Compare
david-allison
added
Needs Author Reply
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: Claude Opus 4.6
Purpose / Description
A common pattern in MVI (and some of Compose) is to encapsulate all one-shot side-effects into a wrapper interface.
This is implemented via a Channel, enforcing correct one-shot and buffering behavior
This pattern allows:
How Has This Been Tested?
flowOfDecksReloadedand it worked as expected.Checklist