[Multiple-Profile]feat:profile name validation

[criticalAY]

Purpose / Description

Profile Name validation

Fixes

• Fixes part of Add support for profiles #18117

Approach

NA

How Has This Been Tested?

Unit test

Learning (optional, can help others)

NA

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[david-allison]

Prefer .toString on the class

[david-allison]

Looks great!

ValidationResult is a good abstraction only if you plan to expose these results, I think it's the right call here

[mikehardy]

This seems fine but...

• would obsolete #20653 if merged as it contains that commit but isn't marked as doing so I don't think?
• is to address a valid PR comment from Brayan on that PR, and seemingly nothing else ?

So, I'm thinking the second commit should be on that PR there, and should have been developed there ?, as it's cohesive with the PR comment on that PR?

Either way, this combination of two commits LGTM, that's just PR bookeeping and things like that are velocity killers. But in future I think keep PR work cohesive if it's specifically to address feedback keep it in same PR

small commits are glorious though :)

[mikehardy]

I am aware of the reason for the conflict since I just reviewed the PR that caused it, I'm pulling this locally for fixup+validation and will repush if it passes

good checkpoint anyway as it'll be tested locally rebased to main and I've merged quite a few PRs, I want to run local validation periodically with rebases anyway...

[mikehardy]

indeed - was the hunk I was pretty sure would collide, trivial resolution, local verification working now