feat: improve Study by card state or tag dialog#20805
feat: improve Study by card state or tag dialog#20805Akira2206 wants to merge 1 commit intoankidroid:mainfrom
Conversation
|
Important Maintainers: This PR contains Strings changes
|
|
CI is failing |
1c86c7a to
50b9de0
Compare
|
I ran |
| tools:text="New cards only" | ||
| /> | ||
| </com.google.android.material.textfield.TextInputLayout> | ||
| <androidx.appcompat.widget.AppCompatButton |
There was a problem hiding this comment.
I didn't like the UI, it doesnt go withh the current dialog UI
f3874b2 to
74257f0
Compare
74257f0 to
4561bd8
Compare
|
Looks great! However, I think it'd be even better if it was more compact. For starters, the vertical spacing between the chips could be smaller. Also, the crosses aren't really necessary since the user can use the edit button. |
4561bd8 to
2637466
Compare
|
Hope it's better now WhatsApp.Video.2026-05-02.at.15.29.02.mp4 |
|
It's better, yes, but can we do anything about the edit button? It's eating up half of the space. Perhaps, tapping anywhere on the "ChipGroup" can open the tag dialog instead? |
|
I'm in favor of removing it. |
Assisted-by: Gemini 3 Flash
2637466 to
34ae6d3
Compare







Note
Logic and documentation assisted by Gemini 3 Flash.
Purpose / Description
Improves the "Study by card state or tag" dialog and implements filtering of tags.
Fixes
Approach
AlertDialog.Builder.title(), affecting all custom study sub-dialogsTextInputLayoutthat switch between "Number of days" and "Number of cards" based on theContextMenuOptionselectAll()in apost {}block within the input dialog to improve text selection behaviorCustomStudyDialogand "Confirm" inTagsDialogTextInputLayoutand dynamicisEnabledupdates for the positive button whenfindNotesreturns zero resultsTagsDialogViewModelto accept afilterQuery, ensuring theTagsDialogonly displays tags available for the selectedCustomStudyCardStateviewModel.selectedTagswhile removing unavailable onesdoAfterTextChangedlistener to sanitize numeric input and prevent leading zerosHow Has This Been Tested?
WhatsApp.Video.2026-04-22.at.05.11.48.mp4
Screenshots of affected dialogs
Checklist