Skip to content

feat(study-screen): Reset progress#20822

Merged
david-allison merged 1 commit intoankidroid:mainfrom
BrayanDSO:feat/reset-progress2
Apr 24, 2026
Merged

feat(study-screen): Reset progress#20822
david-allison merged 1 commit intoankidroid:mainfrom
BrayanDSO:feat/reset-progress2

Conversation

@BrayanDSO
Copy link
Copy Markdown
Member

@BrayanDSO BrayanDSO commented Apr 22, 2026

Purpose / Description

It was missing on the new study screen

How Has This Been Tested?

Galaxy Tab S9, Android 16

Screen_Recording_20260422_200405_AnkiDroid.mp4

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@BrayanDSO BrayanDSO force-pushed the feat/reset-progress2 branch from bd1d65a to 3b39743 Compare April 22, 2026 23:37
Copy link
Copy Markdown
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Comment on lines +513 to +514
// TODO handle 'Reset progress' in the ViewModel instead of the activity, once
// a mechanism of showing a progress bar if the operation takes too long is implemented
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-allison david-allison added the Next version Changes to be merged in the next version, to keep the current release stable. label Apr 23, 2026
@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Apr 23, 2026
Copy link
Copy Markdown
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
IMO it could go in right now.

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Apr 24, 2026
@david-allison
Copy link
Copy Markdown
Member

IMO it could go in right now.

Sure, we'll probably have a couple of betas and it seems low risk

@david-allison david-allison added this pull request to the merge queue Apr 24, 2026
Merged via the queue into ankidroid:main with commit ad8c2c1 Apr 24, 2026
15 checks passed
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Apr 24, 2026
@github-actions github-actions Bot added this to the 2.24 release milestone Apr 24, 2026
@david-allison david-allison removed the Next version Changes to be merged in the next version, to keep the current release stable. label Apr 24, 2026
@BrayanDSO BrayanDSO deleted the feat/reset-progress2 branch April 26, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants