fix: ACRA crash reporting#20856
Merged
lukstbit merged 1 commit intoankidroid:mainfrom Apr 25, 2026
Merged
Conversation
Cause: 0da67f4 Moving to a `java-library` bundled a second copy of `org.json` which uses an incompatible `JSONWriter`. On a release build, R8 inlining causes a crash. `compileOnly` ensures the JAR is not copied over, and the Android `org.json` implementation is used Fixes 20852 Assisted-by: Claude Opus 4.7 - explaining the bug
BrayanDSO
added
Needs Second Approval
lukstbit
approved these changes
Apr 25, 2026
lukstbit
added
Pending Merge
github-actions
Bot
removed
Pending Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: Claude Opus 4.7 - explaining the bug
Purpose / Description
Moving to a
java-librarybundled a second copy oforg.jsonwhich uses an incompatibleJSONWriter.On a release build, R8 inlining causes a crash.
Fixes
JSONStringer:NoSuchFieldError] #20852Approach
compileOnlyensures the JAR is not copied over, and the Androidorg.jsonimplementation is usedHow Has This Been Tested?
The same command I used in my bisects
unset TEST_RELEASE_BUILD && ./gradlew :AnkiDroid:assemblePlayRelease && adb uninstall com.ichi2.anki ; adb install /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/build/outputs/apk/play/release/AnkiDroid-play-arm64-v8a-release.apkLearning
:common:androidfrom:common#20731Checklist