Skip to content

refactor: extract isSdCardMounted from AnkiDroidApp to :common:android#20925

Open
criticalAY wants to merge 1 commit intoankidroid:mainfrom
criticalAY:refactor/common-sdcard
Open

refactor: extract isSdCardMounted from AnkiDroidApp to :common:android#20925
criticalAY wants to merge 1 commit intoankidroid:mainfrom
criticalAY:refactor/common-sdcard

Conversation

@criticalAY
Copy link
Copy Markdown
Contributor

Purpose / Description

Moving a step closer to extracting widget and finally feature to module, the PR extract isSdCardMounted to :common:android

Fixes

Approach

See commit

How Has This Been Tested?

Local build

Learning (optional, can help others)

NA

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

- Will remove a dependency on AnkiDroidApp.Companion to help break circular dependencies when adding feature modules later
@criticalAY criticalAY changed the title refactor: extract 'isSdCardMounted' from AnkiDroidApp to :common:android refactor: extract isSdCardMounted from AnkiDroidApp to :common:android May 2, 2026
@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels May 2, 2026
Copy link
Copy Markdown
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd prefer it if this were also refactored to an SdCard object in a second commit

Implementers choice, merge at will

@david-allison david-allison added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels May 3, 2026
@criticalAY
Copy link
Copy Markdown
Contributor Author

criticalAY commented May 3, 2026

Sure! I will make the change here itself

@david-allison
Copy link
Copy Markdown
Member

david-allison commented May 3, 2026

Maybe something useful here in terms of ideas: https://github.com/david-allison/Anki-Android/commits/sdcard/

EDIT: There's SdCard.isMounted in commit 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants