refactor: extract isSdCardMounted from AnkiDroidApp to :common:android#20925
Open
criticalAY wants to merge 1 commit intoankidroid:mainfrom
Open
refactor: extract isSdCardMounted from AnkiDroidApp to :common:android#20925criticalAY wants to merge 1 commit intoankidroid:mainfrom
isSdCardMounted from AnkiDroidApp to :common:android#20925criticalAY wants to merge 1 commit intoankidroid:mainfrom
Conversation
- Will remove a dependency on AnkiDroidApp.Companion to help break circular dependencies when adding feature modules later
:common:androidisSdCardMounted from AnkiDroidApp to :common:android
BrayanDSO
approved these changes
May 2, 2026
david-allison
approved these changes
May 2, 2026
Member
david-allison
left a comment
There was a problem hiding this comment.
LGTM. I'd prefer it if this were also refactored to an SdCard object in a second commit
Implementers choice, merge at will
Contributor
Author
|
Sure! I will make the change here itself |
Member
|
Maybe something useful here in terms of ideas: https://github.com/david-allison/Anki-Android/commits/sdcard/ EDIT: There's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Moving a step closer to extracting widget and finally feature to module, the PR extract
isSdCardMountedto:common:androidFixes
Approach
See commit
How Has This Been Tested?
Local build
Learning (optional, can help others)
NA
Checklist
Please, go through these checks before submitting the PR.