refactor: extract applicationScope from AnkiDroidApp to :common:android#20926
Merged
david-allison merged 1 commit intoankidroid:mainfrom May 3, 2026
Merged
Conversation
BrayanDSO
approved these changes
May 2, 2026
| // Main was accessed when the platform dispatcher was absent and the test dispatcher | ||
| // was unset | ||
| val applicationScope: CoroutineScope by lazy { | ||
| CoroutineScope(SupervisorJob() + Dispatchers.Main.immediate) |
Member
There was a problem hiding this comment.
for the future (not related to this PR), maybe ProcessLifecycleOwner.get().lifecycleScope should be used for this goal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Again one step forward to clean and organised code, extracting
applicationScopefrom AnkiDroidAppFixes
Approach
See commit
How Has This Been Tested?
Local build and tests pass
Learning (optional, can help others)
NA
Checklist
Please, go through these checks before submitting the PR.