feat(card-browser): edge to edge support & code cleanup

[david-allison]

Note

Assisted-by: Claude Opus 4.7 - understanding and fix of windowBackground issue
Assisted-by: Claude Fable 5 - last commit

Fixes

• Fixes part of Forward-port UI to new edge-to-edge for API35 #17334

How Has This Been Tested?

API 24 + API 33 emulators, private branch with Roborazzi

(scrolling to the bottom does not truncate rows)

Subject: [PATCH] !!edge to edge
---
Index: AnkiDroid/src/main/res/values-v35/theme_black.xml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/AnkiDroid/src/main/res/values-v35/theme_black.xml b/AnkiDroid/src/main/res/values-v35/theme_black.xml
--- a/AnkiDroid/src/main/res/values-v35/theme_black.xml	(revision 182e7993e1207d0c493df461beefb86e3d098849)
+++ b/AnkiDroid/src/main/res/values-v35/theme_black.xml	(revision 713e19ef60adb5637dc9243525f447dbe4e7b2cf)
@@ -15,9 +15,5 @@
   -->
 
 <resources xmlns:tools="http://schemas.android.com/tools" tools:ignore="DuplicateCrowdInStrings">
-    <style name="Base.V35.Dark.Black" parent="@style/Base.Theme.Dark.Black">
-        <item name="android:windowOptOutEdgeToEdgeEnforcement">true</item>
-    </style>
-
-    <style name="Theme_Dark.Black" parent="Base.V35.Dark.Black"/>
+    <style name="Theme_Dark.Black" parent="@style/Base.Theme.Dark.Black"/>
 </resources>
\ No newline at end of file
Index: AnkiDroid/src/main/res/values-v35/theme_dark.xml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/AnkiDroid/src/main/res/values-v35/theme_dark.xml b/AnkiDroid/src/main/res/values-v35/theme_dark.xml
--- a/AnkiDroid/src/main/res/values-v35/theme_dark.xml	(revision 182e7993e1207d0c493df461beefb86e3d098849)
+++ b/AnkiDroid/src/main/res/values-v35/theme_dark.xml	(revision 713e19ef60adb5637dc9243525f447dbe4e7b2cf)
@@ -15,9 +15,5 @@
   -->
 
 <resources xmlns:tools="http://schemas.android.com/tools" tools:ignore="DuplicateCrowdInStrings">
-    <style name="Base.V35.Dark" parent="Base.V29.Dark">
-        <item name="android:windowOptOutEdgeToEdgeEnforcement">true</item>
-    </style>
-
-    <style name="Theme_Dark" parent="Base.V35.Dark"/>
+    <style name="Theme_Dark" parent="Base.V29.Dark"/>
 </resources>
Index: AnkiDroid/src/main/res/values-v35/theme_light.xml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/AnkiDroid/src/main/res/values-v35/theme_light.xml b/AnkiDroid/src/main/res/values-v35/theme_light.xml
--- a/AnkiDroid/src/main/res/values-v35/theme_light.xml	(revision 182e7993e1207d0c493df461beefb86e3d098849)
+++ b/AnkiDroid/src/main/res/values-v35/theme_light.xml	(revision 713e19ef60adb5637dc9243525f447dbe4e7b2cf)
@@ -16,9 +16,5 @@
   -->
 
 <resources xmlns:tools="http://schemas.android.com/tools" tools:ignore="DuplicateCrowdInStrings">
-    <style name="Base.V35.Light" parent="Base.V29.Light">
-        <item name="android:windowOptOutEdgeToEdgeEnforcement">true</item>
-    </style>
-
-    <style name="Theme_Light" parent="Base.V35.Light"/>
+    <style name="Theme_Light" parent="Base.V29.Light"/>
 </resources>
Index: AnkiDroid/src/main/res/values-v35/theme_plain.xml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/AnkiDroid/src/main/res/values-v35/theme_plain.xml b/AnkiDroid/src/main/res/values-v35/theme_plain.xml
--- a/AnkiDroid/src/main/res/values-v35/theme_plain.xml	(revision 182e7993e1207d0c493df461beefb86e3d098849)
+++ b/AnkiDroid/src/main/res/values-v35/theme_plain.xml	(revision 713e19ef60adb5637dc9243525f447dbe4e7b2cf)
@@ -15,9 +15,5 @@
   -->
 
 <resources xmlns:tools="http://schemas.android.com/tools" tools:ignore="DuplicateCrowdInStrings">
-    <style name="Base.V29.Light.Plain" parent="@style/Base.Theme.Light.Plain">
-        <item name="android:windowOptOutEdgeToEdgeEnforcement">true</item>
-    </style>
-
-    <style name="Theme_Light.Plain" parent="Base.V29.Light.Plain"/>
+    <style name="Theme_Light.Plain" parent="@style/Base.Theme.Light.Plain"/>
 </resources>
\ No newline at end of file
Index: gradle/libs.versions.toml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
--- a/gradle/libs.versions.toml	(revision 182e7993e1207d0c493df461beefb86e3d098849)
+++ b/gradle/libs.versions.toml	(revision 713e19ef60adb5637dc9243525f447dbe4e7b2cf)
@@ -10,7 +10,7 @@
 # The API should be as low as possible in order to enable dependencies to stay on a lower minSdk.
 apiMinSdk = "16"
 
-targetSdk = "35"  # affects which SDKs download in ../robolectricDownloader.gradle
+targetSdk = "36"  # affects which SDKs download in ../robolectricDownloader.gradle
 acra = '5.13.1'
 ktlint = '1.8.0'
 # AGP is included in Android Studio and changelogs are not well maintained/at a stable URL

Checklist

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[david-allison]

I want to fix this for rounded corners and the RecyclerFastScroller

[github-actions]

Snapshot diff report vs main. Open screenshot-diff for diffs.

• CardBrowserScreenshotTest: 2 changes

All 2 changed screenshots

CardBrowserScreenshotTest

• 30_notes_compare.png
• scrolled_to_bottom_compare.png

[david-allison]

Handling Corners

When scrolled to the bottom, no clickable elements should be obscured by corners, even slightly.

This means that the following should be aligned when scrolled to the bottom:

• top of the bottom corner
• bottom of the scroll track
• bottom of the scroll handle
• last row

In addition: if the bottom of the last row is visible on the screen, the bottom of the track should match the bottom of the last row (scrolling up, once there are no more rows).

Rough plan: when scrolled to the bottom (Google Pixel 9 Pro)