feat(card-browser): edge to edge support & code cleanup#20938
Open
david-allison wants to merge 5 commits intoankidroid:mainfrom
Open
feat(card-browser): edge to edge support & code cleanup#20938david-allison wants to merge 5 commits intoankidroid:mainfrom
david-allison wants to merge 5 commits intoankidroid:mainfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
b6e5519 to
1815add
Compare
This comment was marked as resolved.
This comment was marked as resolved.
95ed22c to
d126936
Compare
For activities with 'Theme_Dark.Launcher', android:windowBackground is set, but was never removed. On views with transparent backgrounds (such as the Card Browser column headers), this leaked through when edge to edge was enabled Part of issue 17334 - Edge to Edge Assisted-by: Claude Opus 4.7 - diagnostics + fix
Roborazzi test added to catch future regressions Issue 17334 - edge to edge Assisted-by: Claude Opus 4.7 - unit tests
A wrapper was required for the toolbar: adding padding increased the height from minHeight, so apply the padding to a parent element. Roborazzi test added to catch future regressions Issue 17334 Assisted-by: Claude Opus 4.7 - unit tests + frame fix, rest was my own
Added at bind time in BrowserMultiColumnAdapter.kt Assisted-by: Claude Opus 4.7 - diagnostic
d126936 to
725a33e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: Claude Opus 4.7 - understanding and fix of
windowBackgroundissueFixes
How Has This Been Tested?
API 24 + API 33 emulators, private branch with Roborazzi
(scrolling to the bottom does not truncate rows)
Checklist