feat(card-browser): implement 'Default search text'#20955
Open
david-allison wants to merge 4 commits intoankidroid:mainfrom
Open
feat(card-browser): implement 'Default search text'#20955david-allison wants to merge 4 commits intoankidroid:mainfrom
david-allison wants to merge 4 commits intoankidroid:mainfrom
Conversation
* Simplifies the ViewModel, it's getting large Assisted-by: Claude Opus 4.7 - all
Assisted-by: Claude Opus 4.7 - all
Fixes 18618 Assisted-by: Claude Opus 4.7 - all
android:textColorHint was #79747E. On #E4F5FD this led to a contrast of 4.07:1 #716C76 is 4.57:1 - acceptable for text Assisted-by: Claude Opus 4.7 - color
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: Claude Opus 4.7
Purpose / Description
Upstream functionality, only implemented in the new card browser
Fixes
Approach
I performed a few initial refactors, partially as logic shouldn't be in the
saveChangesmethod, partially to reduce the code in the ViewModelHow Has This Been Tested?
Unit tests
Checklist