Skip to content

refactor: extract 'unregisterReceiverSilently' to :common:android#20957

Merged
david-allison merged 1 commit intoankidroid:mainfrom
criticalAY:refactor/unregisterReceiverSilently
May 6, 2026
Merged

refactor: extract 'unregisterReceiverSilently' to :common:android#20957
david-allison merged 1 commit intoankidroid:mainfrom
criticalAY:refactor/unregisterReceiverSilently

Conversation

@criticalAY
Copy link
Copy Markdown
Contributor

Purpose / Description

And one more, -> Removes a dependency on com.ichi2.anki.utils.ext from widget config activities, helping break circular dependencies for feature module extraction

Fixes

Approach

See commit

How Has This Been Tested?

Local build

Learning (optional, can help others)

NA

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

…roid

Removes a dependency on com.ichi2.anki.utils.ext from widget config
activities, helping break circular dependencies for feature module
extraction
Copy link
Copy Markdown
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also an argument that this extension method could live inside the :widgets module

Implementer's choice. Merge at will

@david-allison david-allison added Needs Author Reply Waiting for a reply from the original author Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Review labels May 5, 2026
@criticalAY
Copy link
Copy Markdown
Contributor Author

I think it can stay in common maybe later if we feel that its actually not the right place then, hitting merge

@criticalAY criticalAY removed the Needs Author Reply Waiting for a reply from the original author label May 6, 2026
@criticalAY criticalAY enabled auto-merge May 6, 2026 10:21
@david-allison david-allison disabled auto-merge May 6, 2026 14:45
@david-allison david-allison enabled auto-merge May 6, 2026 14:45
@david-allison david-allison added this pull request to the merge queue May 6, 2026
Merged via the queue into ankidroid:main with commit 020740a May 6, 2026
22 of 23 checks passed
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label May 6, 2026
@github-actions github-actions Bot added this to the 2.25 release milestone May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants