refactor: extract 'unregisterReceiverSilently' to :common:android#20957
Merged
david-allison merged 1 commit intoankidroid:mainfrom May 6, 2026
Merged
Conversation
…roid Removes a dependency on com.ichi2.anki.utils.ext from widget config activities, helping break circular dependencies for feature module extraction
david-allison
approved these changes
May 5, 2026
Member
david-allison
left a comment
There was a problem hiding this comment.
There's also an argument that this extension method could live inside the :widgets module
Implementer's choice. Merge at will
Contributor
Author
|
I think it can stay in common maybe later if we feel that its actually not the right place then, hitting merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
And one more, -> Removes a dependency on com.ichi2.anki.utils.ext from widget config activities, helping break circular dependencies for feature module extraction
Fixes
Approach
See commit
How Has This Been Tested?
Local build
Learning (optional, can help others)
NA
Checklist
Please, go through these checks before submitting the PR.