fix: avoid anchoring reviewer snackbar to hidden answer buttons#20958
Merged
BrayanDSO merged 1 commit intoankidroid:mainfrom May 6, 2026
Merged
fix: avoid anchoring reviewer snackbar to hidden answer buttons#20958BrayanDSO merged 1 commit intoankidroid:mainfrom
BrayanDSO merged 1 commit intoankidroid:mainfrom
Conversation
Contributor
Author
|
@david-allison AbstractFlashcardViewer.kt will be gone when we finally enable new SS and get rid of this one (No action needed) |
lukstbit
approved these changes
May 6, 2026
BrayanDSO
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
In FullScreenMode.FULLSCREEN_ALL_GONE, the answer buttons layout is animated to View.GONE when the system UI auto-hides. Snackbars shown during that window (e.g. via undoAndShowSnackbar) anchored to the hidden view and tripped the visibility check in showSnackbar. Guard the anchor with takeIf { it.isVisible }, mirroring the fixapplied to DeckPicker in #20766.
Fixes
Approach
NA
How Has This Been Tested?
Google emulator API 35, I have verified it doesnt occur in new study screen only in old one
Learning (optional, can help others)
NA
Checklist
Please, go through these checks before submitting the PR.