feat: create :widgets module#21128
Open
criticalAY wants to merge 1 commit into
Open
Conversation
criticalAY
force-pushed
the
widget/module
branch
2 times, most recently
from
014cb23 to
ec2f726
Compare
Member
There was a problem hiding this comment.
Awesome!!!! 🥳🥳🎂🎂🎂
- Please add a README with plans
- For example: moving the widgets AndroidManifest
Please rename "java" to "kotlin" in the file path for the source filesthis is a minor improvement in the IDE view- EDIT: This needs source set work
Note for the future: I feel this would be too early for another module which churns more. This change means developers have two places to look for classes
david-allison
added
the
Needs Author Reply
- First step of widget module extraction. Creates :widgets and moves three files that have no dependencies on the :AnkiDroid module - Id.kt (AppWidgetId/AppWidgetIds value classes + AppWidgetManager extensions) - cardanalysis/CardAnalysisWidgetPreferences.kt - deckpicker/DeckPickerWidgetPreferences.kt
criticalAY
force-pushed
the
widget/module
branch
from
ec2f726 to
32fcd4e
Compare
david-allison
left a comment
david-allison
left a comment
Member
There was a problem hiding this comment.
Needs a very brief README with plans, I feel
Rest LGTM, let's get this moving!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Establishes a :widgets Gradle module as the first step toward physically extracting widget code out of :AnkiDroid. This is the smallest viable module creation change
Fixes
Approach
See commit
How Has This Been Tested?
Local build and Pixel 10 tried adding widgets and additionally, no behavior change in the moved files (pure relocation, package unchanged), so no manual UI test is necessary.
Learning (optional, can help others)
NA
Checklist
Please, go through these checks before submitting the PR.