Skip to content

Fix #20763: Match Scheduler.answerCard with upstream Anki#21163

Merged
david-allison merged 1 commit into
ankidroid:mainfrom
vivek41-glitch:main
May 30, 2026
Merged

Fix #20763: Match Scheduler.answerCard with upstream Anki#21163
david-allison merged 1 commit into
ankidroid:mainfrom
vivek41-glitch:main

Conversation

@vivek41-glitch

Copy link
Copy Markdown
Contributor

Fixes #20763

Replace queuedCards.cardsList.first() with col.backend.getSchedulingStates(card.id) to match upstream Python implementation.

@vivek41-glitch

Copy link
Copy Markdown
Contributor Author

This PR fixes #20763 by replacing queuedCards.cardsList.first() with col.backend.getSchedulingStates(card.id) to match upstream Anki.
I understand there are extra commits in this PR. I'm new to Git and would greatly appreciate it if you could squash the commits when merging.
Thank you

@david-allison

This comment was marked as resolved.

@david-allison david-allison added Needs Author Reply Waiting for a reply from the original author and removed Needs Review labels May 28, 2026
@vivek41-glitch

This comment was marked as resolved.

@DoomsCoder

This comment was marked as resolved.

@vivek41-glitch

Copy link
Copy Markdown
Contributor Author

thanks @DoomsCoder for guiding , and @david-allison all test passed including kotlin issue , now ready for final review.

david-allison

This comment was marked as resolved.

@david-allison david-allison left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!!

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Author Reply Waiting for a reply from the original author labels May 29, 2026

@DoomsCoder DoomsCoder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers 🥂

@sanjaysargam sanjaysargam left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vivek41-glitch Thanks for the contribution keep up the good work!
For future PRs, please create a separate branch for each PR. It’s a safer and more organized workflow, and it helps avoid conflicts between changes.

@sanjaysargam

Copy link
Copy Markdown
Member

@vivek41-glitch
Small GitHub note 😄 your commit identity is currently showing as plain text instead of linking to your GitHub profile.
This usually happens when the git email used for commits does not match an email added to your GitHub account, so the contribution may not appear correctly in your contribution graph/activity heatmap.

You can fix it by checking your git config:

git config --global user.name
git config --global user.email

and making sure the email matches one of the emails added in GitHub
If needed, you can update it with:

git config --global user.name "your-github-username"
git config --global user.email "your-github-email@example.com"

Future commits should then get linked properly to your GitHub profile.

@vivek41-glitch

Copy link
Copy Markdown
Contributor Author

@sanjaysargam thanks for helping . and from furthur i will creat new branch for every pr , and i did connect my github with email .
waiting to get merge , cheers!

@sanjaysargam

Copy link
Copy Markdown
Member

@vivek41-glitch you should reset this commit and commit again and push, then only it will reflect here.
Thanks

@vivek41-glitch

Copy link
Copy Markdown
Contributor Author

@sanjaysargam done, recommitted with correct author identity. Thanks

@sanjaysargam sanjaysargam added this pull request to the merge queue May 30, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 30, 2026
@david-allison david-allison added this pull request to the merge queue May 30, 2026
Merged via the queue into ankidroid:main with commit 3e0bc30 May 30, 2026
20 checks passed
@github-actions github-actions Bot added this to the 2.25 release milestone May 30, 2026
@github-actions github-actions Bot removed the Needs Second Approval Has one approval, one more approval to merge label May 30, 2026
@vivek41-glitch

Copy link
Copy Markdown
Contributor Author

thanks to all of u for guiding me @david-allison @DoomsCoder @sanjaysargam , i hope will contribute more to ankidroid.
cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[API] Scheduler.answerCard NoSuchElementException: List is empty.

4 participants