Fix #20763: Match Scheduler.answerCard with upstream Anki#21163
Conversation
|
This PR fixes #20763 by replacing queuedCards.cardsList.first() with col.backend.getSchedulingStates(card.id) to match upstream Anki. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
thanks @DoomsCoder for guiding , and @david-allison all test passed including kotlin issue , now ready for final review. |
sanjaysargam
left a comment
There was a problem hiding this comment.
@vivek41-glitch Thanks for the contribution keep up the good work!
For future PRs, please create a separate branch for each PR. It’s a safer and more organized workflow, and it helps avoid conflicts between changes.
|
@vivek41-glitch You can fix it by checking your git config: and making sure the email matches one of the emails added in GitHub Future commits should then get linked properly to your GitHub profile. |
|
@sanjaysargam thanks for helping . and from furthur i will creat new branch for every pr , and i did connect my github with email . |
|
@vivek41-glitch you should reset this commit and commit again and push, then only it will reflect here. |
|
@sanjaysargam done, recommitted with correct author identity. Thanks |
|
thanks to all of u for guiding me @david-allison @DoomsCoder @sanjaysargam , i hope will contribute more to ankidroid. |
Fixes #20763
Replace queuedCards.cardsList.first() with col.backend.getSchedulingStates(card.id) to match upstream Python implementation.