Skip to content

lint: mark 14 rules as 'fatal'#21167

Open
david-allison wants to merge 3 commits into
ankidroid:mainfrom
david-allison:lint-recycle
Open

lint: mark 14 rules as 'fatal'#21167
david-allison wants to merge 3 commits into
ankidroid:mainfrom
david-allison:lint-recycle

Conversation

@david-allison
Copy link
Copy Markdown
Member

@david-allison david-allison commented May 28, 2026

Note

Assisted-by: Claude Opus 4.8

12 are safe to turn on without producing errors

one had a few test-only fixes
one had fixes required

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label May 29, 2026
These are safe to turn on without producing errors
Assisted-by: Claude Opus 4.8 - implementation
* Fixes usage analytics by using the Application context
* Use `Application` where it's a false positive
@david-allison david-allison removed the Needs Author Reply Waiting for a reply from the original author label May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant