lint: mark 14 rules as 'fatal'#21167
Open
david-allison wants to merge 3 commits into
Open
Conversation
cfa46e4 to
81b8395
Compare
These are safe to turn on without producing errors
Assisted-by: Claude Opus 4.8 - implementation
* Fixes usage analytics by using the Application context * Use `Application` where it's a false positive
81b8395 to
d24b1e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: Claude Opus 4.8
12 are safe to turn on without producing errors
one had a few test-only fixes
one had fixes required
Checklist