Skip to content

fix: remove unnecessary onCreate calls#21172

Merged
criticalAY merged 1 commit into
ankidroid:mainfrom
david-allison:fix-oncreatedialog
May 30, 2026
Merged

fix: remove unnecessary onCreate calls#21172
criticalAY merged 1 commit into
ankidroid:mainfrom
david-allison:fix-oncreatedialog

Conversation

@david-allison

Copy link
Copy Markdown
Member

Note

Assisted-by: Claude Opus 4.8 - investigation and fix

Purpose / Description

super.onCreateDialog was not required, as the classes returned a custom dialog

Fixes

How Has This Been Tested?

Opened 'CustomStudyDialog'

Trusting Ci

Learning

Added in ae7d237

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison changed the title fix: remove unnecessary onCreate call fix: remove unnecessary onCreate calls May 29, 2026
super.onCreateDialog was not required, as the classes
returned a custom dialog.

Introduced in ae7d237
and copy-pasted.

Fixes 21171

Assisted-by: Claude Opus 4.8 - investigation and fix

@lukstbit lukstbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I don't see why we would ever want to manually call other lifecycle methods.
Very old dialogs, probably some ancient forgotten lore + one dialog from me(definitely a mistake)

@lukstbit lukstbit added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels May 29, 2026
@criticalAY criticalAY added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels May 30, 2026
@criticalAY criticalAY added this pull request to the merge queue May 30, 2026
Merged via the queue into ankidroid:main with commit 22da9a4 May 30, 2026
20 checks passed
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label May 30, 2026
@github-actions github-actions Bot added this to the 2.25 release milestone May 30, 2026
@david-allison david-allison deleted the fix-oncreatedialog branch May 30, 2026 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: onCreateDialog calls super.onCreate

3 participants