diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/CardBrowserOrderDialog.kt b/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/CardBrowserOrderDialog.kt index 02bd6492660b..be043be6d9d0 100644 --- a/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/CardBrowserOrderDialog.kt +++ b/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/CardBrowserOrderDialog.kt @@ -33,7 +33,6 @@ class CardBrowserOrderDialog : AnalyticsDialogFragment() { private val viewModel: CardBrowserViewModel by activityViewModels() override fun onCreateDialog(savedInstanceState: Bundle?): Dialog { - super.onCreate(savedInstanceState) val items = resources.getStringArray(R.array.card_browser_order_labels) // Set sort order arrow for (i in items.indices) { diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/ConfirmationDialog.kt b/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/ConfirmationDialog.kt index 540648e6f024..1071b7642e95 100644 --- a/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/ConfirmationDialog.kt +++ b/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/ConfirmationDialog.kt @@ -85,16 +85,13 @@ class ConfirmationDialog : DialogFragment() { this.cancel = cancel } - override fun onCreateDialog(savedInstanceState: Bundle?): AlertDialog { - super.onCreate(savedInstanceState) - - return AlertDialog.Builder(requireContext()).create { + override fun onCreateDialog(savedInstanceState: Bundle?): AlertDialog = + AlertDialog.Builder(requireContext()).create { title(text = title) message(text = message) positiveButton(text = positiveButtonText) { confirm.run() } negativeButton(R.string.dialog_cancel) { cancel.run() } } - } companion object { /** The dialog message (required) */ diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/DeckPickerBackupNoSpaceLeftDialog.kt b/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/DeckPickerBackupNoSpaceLeftDialog.kt index 5aaf75e5ca20..504929156a3b 100644 --- a/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/DeckPickerBackupNoSpaceLeftDialog.kt +++ b/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/DeckPickerBackupNoSpaceLeftDialog.kt @@ -30,7 +30,6 @@ import com.ichi2.utils.title class DeckPickerBackupNoSpaceLeftDialog : AnalyticsDialogFragment() { override fun onCreateDialog(savedInstanceState: Bundle?): AlertDialog { - super.onCreate(savedInstanceState) val res = resources val space = BackupManager.getFreeDiscSpace(CollectionHelper.getCollectionPath(requireActivity())) return AlertDialog diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/DeckPickerContextMenu.kt b/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/DeckPickerContextMenu.kt index f2ef9c48df01..e5f44cd6308a 100644 --- a/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/DeckPickerContextMenu.kt +++ b/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/DeckPickerContextMenu.kt @@ -37,7 +37,6 @@ import com.ichi2.utils.title class DeckPickerContextMenu : AnalyticsDialogFragment() { override fun onCreateDialog(savedInstanceState: Bundle?): Dialog { - super.onCreate(savedInstanceState) require(requireArguments().containsKey(ARG_DECK_ID)) { "Missing argument deck id" } require(requireArguments().containsKey(ARG_DECK_NAME)) { "Missing argument deck name" } require(requireArguments().containsKey(ARG_DECK_IS_DYN)) { "Missing argument deck is dynamic" } diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/DeckPickerNoSpaceLeftDialog.kt b/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/DeckPickerNoSpaceLeftDialog.kt index 99a5b23dce15..b499f37f1b39 100644 --- a/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/DeckPickerNoSpaceLeftDialog.kt +++ b/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/DeckPickerNoSpaceLeftDialog.kt @@ -16,7 +16,6 @@ package com.ichi2.anki.dialogs -import android.app.Dialog import android.os.Bundle import androidx.appcompat.app.AlertDialog import com.ichi2.anki.R @@ -28,16 +27,14 @@ import com.ichi2.utils.positiveButton import com.ichi2.utils.title class DeckPickerNoSpaceLeftDialog : AnalyticsDialogFragment() { - override fun onCreateDialog(savedInstanceState: Bundle?): Dialog { - super.onCreate(savedInstanceState) - return AlertDialog.Builder(requireActivity()).create { + override fun onCreateDialog(savedInstanceState: Bundle?) = + AlertDialog.Builder(requireActivity()).create { title(R.string.storage_full_title) message(R.string.backup_deck_no_storage_left) cancelable(true) positiveButton(R.string.dialog_ok) {} setOnCancelListener {} } - } companion object { fun newInstance(): DeckPickerNoSpaceLeftDialog = DeckPickerNoSpaceLeftDialog() diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/ImportDialog.kt b/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/ImportDialog.kt index 681e75d6730b..960538e632fe 100644 --- a/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/ImportDialog.kt +++ b/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/ImportDialog.kt @@ -43,7 +43,6 @@ class ImportDialog : AsyncDialogFragment() { get() = requireArguments().getString(IMPORT_DIALOG_PACKAGE_PATH_KEY)!! override fun onCreateDialog(savedInstanceState: Bundle?): AlertDialog { - super.onCreate(savedInstanceState) val dialog = AlertDialog.Builder(requireActivity()) dialog.setCancelable(true) val displayFileName = filenameFromPath(convertToDisplayName(packagePath)) diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/NoteTypeFieldEditorContextMenu.kt b/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/NoteTypeFieldEditorContextMenu.kt index 5e3db068d938..50fa9bd867b4 100644 --- a/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/NoteTypeFieldEditorContextMenu.kt +++ b/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/NoteTypeFieldEditorContextMenu.kt @@ -21,7 +21,6 @@ import timber.log.Timber class NoteTypeFieldEditorContextMenu : AnalyticsDialogFragment() { @SuppressLint("CheckResult") override fun onCreateDialog(savedInstanceState: Bundle?): Dialog { - super.onCreate(savedInstanceState) val availableItems = NoteTypeFieldEditorContextMenuAction.entries.sortedBy { it.order } return AlertDialog.Builder(requireActivity()).create { diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/SavedBrowserSearchesDialogFragment.kt b/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/SavedBrowserSearchesDialogFragment.kt index 08f4d2bf56b1..c23d7693783d 100644 --- a/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/SavedBrowserSearchesDialogFragment.kt +++ b/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/SavedBrowserSearchesDialogFragment.kt @@ -49,7 +49,6 @@ import timber.log.Timber // dialog(or maybe even add an option to remove all entries directly) class SavedBrowserSearchesDialogFragment : AnalyticsDialogFragment() { override fun onCreateDialog(savedInstanceState: Bundle?): Dialog { - super.onCreate(savedInstanceState) val savedFilters: HashMap? = requireArguments().getSerializableCompat(ARG_SAVED_FILTERS) val data = diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/SyncErrorDialog.kt b/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/SyncErrorDialog.kt index 1200b4637249..e571bc701fd9 100644 --- a/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/SyncErrorDialog.kt +++ b/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/SyncErrorDialog.kt @@ -67,7 +67,6 @@ class SyncErrorDialog : AsyncDialogFragment() { get() = Type.fromCode(requireArguments().getInt(SYNC_ERROR_DIALOG_TYPE_KEY)) override fun onCreateDialog(savedInstanceState: Bundle?): Dialog { - super.onCreate(savedInstanceState) val dialog = AlertDialog .Builder(requireContext()) diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/customstudy/CustomStudyDialog.kt b/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/customstudy/CustomStudyDialog.kt index dba640f967dd..6c4b90ef7964 100644 --- a/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/customstudy/CustomStudyDialog.kt +++ b/AnkiDroid/src/main/java/com/ichi2/anki/dialogs/customstudy/CustomStudyDialog.kt @@ -179,7 +179,6 @@ class CustomStudyDialog : AnalyticsDialogFragment() { } override fun onCreateDialog(savedInstanceState: Bundle?): Dialog { - super.onCreate(savedInstanceState) val option = selectedSubDialog return if (option == null || !defaultsAreInitialized()) { Timber.i("Showing Custom Study main menu")