feat: add card flags to CardContentProvider and api#21322
Open
ColgateTotal77 wants to merge 4 commits into
Open
feat: add card flags to CardContentProvider and api#21322ColgateTotal77 wants to merge 4 commits into
ColgateTotal77 wants to merge 4 commits into
Conversation
|
First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible. |
sanjaysargam
requested changes
Jul 1, 2026
sanjaysargam
left a comment
Member
There was a problem hiding this comment.
Welcome to the community @ColgateTotal77
Thanks for contributing 🚀
…r.kt and update testSetFlagCard
criticalAY
requested changes
Jul 1, 2026
criticalAY
left a comment
Contributor
There was a problem hiding this comment.
Really strong first PR, thank you!
Contributor
|
The comments are not resolved? |
Author
Hi, closed some, but can you look at #21322 (comment) and also do we need to mention David again in #21322 (comment) |
…lag enum. Create separate test for SetUserFlag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Expand CardContentProvider and api to work with card flags.
Fixes
Approach
Added read/write for card flags in CardContentProvider and api.
How Has This Been Tested?
Implemented test for negative, too large, and valid flag codes.
Learning (optional, can help others)
I just looked at other api functions and content provider cases. Most of the code I just copied and a little tweaked for my case.
Checklist