arch(dev-only): handle 'no storage decision' for all activities in ActivityList

[david-allison]

Note

Assisted-by: Claude Fable 5

Purpose / Description

I want collection creation to become part of the onboarding sequence., moving it out of the implicit Collection.withCol

This opens the floor for a 'storage decision': if the user is using a full build - do they want to obtain MANAGE_EXTERNAL_STORAGE, or continue with app-private storage?

In this case, all activities need to handle the possibility that the decision wasn't made yet, or was revoked. Most of these cases have been handled, but these activities remained, typically being launched after process death, or through notifications/app shortcuts.

Fixes

• Follow-on from fix(startup): handle when the user has not decided the storage type (App-Private/Public) #21290
• Related to Consolidate validation in app entry points #19552
• Related to Architecture Discussion: Module Extraction #20737
• Related to Don't force full (F-Droid/GitHub) releases users to grant the All files access permission #13574

Approach

• Redirect users to IntentHandler -> DeckPicker if no storage decision is made
  • A centralized point of handling in IntentHandler, in future to be moved to a selection screen.
• Handle launchCatchingTask
• Scaffold for DeckPicker to handle this issue as an error
  • Normally it would be part of startup; DeckPicker should handle the case that this permission was revoked and allow a user to regain access

How Has This Been Tested?

Unit tested

Checklist

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[criticalAY]

Nitpicks, rest all clean, thanks

[criticalAY]

The function is ensureStorageIsReady