fix: Prevent easy days from being set while touchscreen scrolling#4784
Open
Luc-Mcgrady wants to merge 1 commit into
Open
fix: Prevent easy days from being set while touchscreen scrolling#4784Luc-Mcgrady wants to merge 1 commit into
Luc-Mcgrady wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue (required)
closes ankidroid/Anki-Android#20929
Summary / motivation (required)
People inadvertently set their easy days without noticing while scrolling on mobile. See this forum post.
This resets the easy days to their original values if the user has scrolled while they are being set.
Steps to reproduce (required, use N/A if not applicable)
N/A
How to test (required)
I used
ANKI_API_HOST=0.0.0.0 ./runand browsed tohttp://(host-ip-address):40000/deck-options/1on a mobile device@david-allison would you mind testing this in AnkiDroid?
Checklist (minimum)
./ninja checkor an equivalent relevant check locally.Details
There was a weird issue with
on:touchstartnot working and I had to manually add an event handler which is a little annoying.Before / after behavior (optional)
Risk / compatibility / migration (optional)
UI evidence (required for visual changes; otherwise N/A)
Scope