Skip to content

feat: add Rust test coverage#4842

Merged
fernandolins merged 13 commits into
mainfrom
feat/rust-test-coverage-4839
May 18, 2026
Merged

feat: add Rust test coverage#4842
fernandolins merged 13 commits into
mainfrom
feat/rust-test-coverage-4839

Conversation

@fernandolins
Copy link
Copy Markdown
Contributor

@fernandolins fernandolins commented May 14, 2026

Linked issue

Closes #4839

Summary / motivation

Adds cargo-llvm-cov-based test coverage for the full Rust workspace. Introduces just test-rust --coverage and just test-rust --coverage --html, and wires Rust into the just test --coverage umbrella.

cargo-llvm-cov is installed on demand into out/bin/ to avoid polluting the global cargo install. The llvm-tools-preview rustup component is now installed in CI so the tool can instrument binaries.

How to test (required)

# Existing behavior unchanged
just test-rust

# Terminal summary
just test-rust --coverage

# Terminal summary + HTML report under out/coverage/rust/html/
just test-rust --coverage --html

# Umbrella (Rust + Python)
just test --coverage
just test --coverage --html

Note: first run of --coverage will install cargo-llvm-cov into
out/bin/ (~30s). Subsequent runs skip the install step.

Checklist

  • I ran ./ninja check or an equivalent relevant check locally.

Details

  • cargo-llvm-cov pinned at 0.8.4, installed into out/bin/ via cargo install --root out.
  • --workspace --locked measures all crates and respects the lockfile.
  • llvm-tools-preview added to setup-anki action so CI can instrument Rust binaries.
  • Coverage runs are slower than plain just test-rust because cargo-llvm-cov rebuilds with instrumentation — this is expected.

Before / after behavior

Before: no just test-rust, no Rust coverage support.

After: just test-rust runs Rust tests via ninja; just test-rust --coverage runs them with cargo-llvm-cov

@fernandolins fernandolins changed the title Feat/rust test coverage 4839 Feat/rust test coverage May 14, 2026
@fernandolins fernandolins changed the title Feat/rust test coverage fest: add Rust test coverage May 14, 2026
@fernandolins fernandolins changed the title fest: add Rust test coverage feat: add Rust test coverage May 14, 2026
@fernandolins fernandolins force-pushed the feat/rust-test-coverage-4839 branch from 0b7db14 to 2bff590 Compare May 15, 2026 13:17
abdnh
abdnh requested changes May 15, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@abdnh abdnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Windows support (see my commit in the Python PR).

@fernandolins Swarmia
Copy link
Copy Markdown
Contributor Author

fernandolins commented May 15, 2026

@abdnh I saw it. I'm working into it! Thanks!

fernandolins and others added 10 commits May 15, 2026 21:28
@fernandolins
feat(test): add Python test coverage via coverage.py
89826a3 
Add just test-py with --coverage and --html flag support, backed by
coverage.py. Runs pylib and qt test suites separately, writes data to
out/coverage/, and enforces minimum line thresholds (65% pylib, 20% qt).

Closes #4838
@fernandolins
feat(test): extend just test to support --coverage and --html flags
2ad52b6 
Update just test to accept --coverage and --html, delegating to a new
coverage recipe. Currently covers Python only.
@fernandolins
ci: enforce coverage on Linux PR builds
e41865e
@abdnh @fernandolins
Add Windows support
37186c6
@fernandolins
feat(test): add Rust test coverage via cargo-llvm-cov
770b142 
Add just test-rust with --coverage and --html flag support, backed by
cargo-llvm-cov. Installs the tool on demand into out/bin/ to avoid
polluting the global cargo install.
@fernandolins
ci: add llvm-tools-preview and wire Rust into coverage umbrella
ad9c8e2 
Install llvm-tools-preview in CI so cargo-llvm-cov can instrument
binaries. Extend the coverage umbrella to run Rust coverage ahead
of Python.
@fernandolins
feat(test): add Windows support for Rust coverage via tools/coverage-…
ae0870d 
…rust

Extract cargo-llvm-cov invocation into tools/coverage-rust (bash) and
tools/coverage-rust.bat (Windows), mirroring the tools/coverage-py
pattern. Simplifies _coverage-rust in the justfile.
@fernandolins
refactor(test): move coverage scripts into tools/coverage/
58810d4
@fernandolins
refactor(test): extract path variables in coverage-rust scripts
c4c7471
@fernandolins
fix(test): skip Rust coverage on Windows ARM64 with clear message
ace294a 
cargo-llvm-cov's llvm-profdata uses the host toolchain, which cannot
merge profraw files produced on aarch64-pc-windows-msvc. Refs:
rust-lang/rust#150123, taiki-e/cargo-llvm-cov#436.
@fernandolins fernandolins force-pushed the feat/rust-test-coverage-4839 branch from 173f712 to ace294a Compare May 16, 2026 00:30
@fernandolins fernandolins force-pushed the feat/python-test-coverage-4838 branch from d422c9e to 37186c6 Compare May 16, 2026 00:30
Base automatically changed from feat/python-test-coverage-4838 to main May 16, 2026 00:34
@fernandolins
Copy link
Copy Markdown
Contributor Author

fernandolins commented May 16, 2026

@abdnh I added the windows support!

@fernandolins fernandolins requested a review from abdnh May 18, 2026 14:21
@read-the-docs-community
Copy link
Copy Markdown

read-the-docs-community Bot commented May 18, 2026 •
edited
Loading

Documentation build overview

📚 Anki | 🛠️ Build #32738953 | 📁 Comparing 8d0209f against latest (cc1605a)

  🔍 Preview build  

2 files changed
± genindex.html
± autoapi/aqt/import_export/exporting/index.html

@fernandolins fernandolins merged commit f76fcec into main May 18, 2026
6 checks passed
@fernandolins fernandolins deleted the feat/rust-test-coverage-4839 branch May 18, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abdnh abdnh abdnh approved these changes

@andrewsanchez andrewsanchez Awaiting requested review from andrewsanchez

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: add Rust test coverage

2 participants

@fernandolins @abdnh