Skip to content

Commit a01afa5

Browse files
committed
fix: rename unused request parameters to _ in tests
Fixes code quality check failure for unused parameters in http.HandlerFunc callbacks that don't need the request object.
1 parent 2e1bd5a commit a01afa5

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

pkg/jira/search_test.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ func TestSearchPagination(t *testing.T) {
169169
}
170170

171171
t.Run("offset skipping within single page", func(t *testing.T) {
172-
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
172+
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
173173
w.Header().Set("Content-Type", "application/json")
174174
w.WriteHeader(200)
175175
// Return 5 issues, client requests from=2, limit=2
@@ -239,7 +239,7 @@ func TestSearchPagination(t *testing.T) {
239239

240240
t.Run("limit stops fetching early", func(t *testing.T) {
241241
requestCount := 0
242-
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
242+
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
243243
requestCount++
244244
w.Header().Set("Content-Type", "application/json")
245245
w.WriteHeader(200)
@@ -311,7 +311,7 @@ func TestSearchPagination(t *testing.T) {
311311
})
312312

313313
t.Run("offset beyond available items returns empty", func(t *testing.T) {
314-
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
314+
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
315315
w.Header().Set("Content-Type", "application/json")
316316
w.WriteHeader(200)
317317
resp := makeResponse([]*Issue{
@@ -332,7 +332,7 @@ func TestSearchPagination(t *testing.T) {
332332
})
333333

334334
t.Run("empty result set", func(t *testing.T) {
335-
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
335+
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
336336
w.Header().Set("Content-Type", "application/json")
337337
w.WriteHeader(200)
338338
resp := makeResponse([]*Issue{}, "", true)
@@ -350,7 +350,7 @@ func TestSearchPagination(t *testing.T) {
350350

351351
t.Run("error mid-pagination returns error", func(t *testing.T) {
352352
requestCount := 0
353-
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
353+
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
354354
requestCount++
355355
w.Header().Set("Content-Type", "application/json")
356356

@@ -408,7 +408,7 @@ func TestSearchPagination(t *testing.T) {
408408
})
409409

410410
t.Run("IsLast true when all pages exhausted", func(t *testing.T) {
411-
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
411+
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
412412
w.Header().Set("Content-Type", "application/json")
413413
w.WriteHeader(200)
414414
// Single page with all results, isLast=true
@@ -429,7 +429,7 @@ func TestSearchPagination(t *testing.T) {
429429
})
430430

431431
t.Run("IsLast false when limit reached before end", func(t *testing.T) {
432-
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
432+
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
433433
w.Header().Set("Content-Type", "application/json")
434434
w.WriteHeader(200)
435435
// Page has more items than requested limit

0 commit comments

Comments
 (0)