PoC: Lambda dev server#61
Draft
renatoalencar wants to merge 1 commit into
Draft
Conversation
c7accee to
5d089a9
Compare
5d089a9 to
9c7e013
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm submitting this an initial proof of concept, so I have something to discuss and raise some questions. The implementation is still very sloppy and it's missing some details, but I would like to ask about some points that are still a little bit obscure for me.
Piaf.Request.tto anEvent.t, I've added a mock function to the interface, but I really think that it shouldn't be there and neither be named just mock. But I'm not sure about the best way of dealing with this.StringMapuses string as values and not lists. TheUrimodule uses(string * string list) listas the type for parsed query strings, although AWS Lambda context has key pair values with single values forqueryStringParametersand key with an array formultiValueQueryStringParameters. I'm not sure how to handle cases with more than one value for the same key forqueryStringParameters. (I should probably take a look on how API Gateway works for that).Cmdliner, butArgwould also work and wouldn't add a new dependency.