Skip to content

Commit 1275d50

Browse files
Apply PR #26387: tui: optimistically render submitted prompts
2 parents 7d7306c + 1462f9c commit 1275d50

4 files changed

Lines changed: 239 additions & 23 deletions

File tree

packages/opencode/src/cli/cmd/tui/component/prompt/index.tsx

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1193,25 +1193,27 @@ export function Prompt(props: PromptProps) {
11931193
})),
11941194
})
11951195
} else {
1196+
const parts = [
1197+
...editorParts,
1198+
{
1199+
id: PartID.ascending(),
1200+
type: "text" as const,
1201+
text: inputText,
1202+
},
1203+
...nonTextParts.map(assign),
1204+
]
1205+
const request = {
1206+
sessionID,
1207+
messageID,
1208+
agent: agent.name,
1209+
model: selectedModel,
1210+
variant,
1211+
parts,
1212+
}
1213+
sync.session.addOptimisticPrompt(request)
11961214
sdk.client.session
1197-
.prompt({
1198-
sessionID,
1199-
...selectedModel,
1200-
messageID,
1201-
agent: agent.name,
1202-
model: selectedModel,
1203-
variant,
1204-
parts: [
1205-
...editorParts,
1206-
{
1207-
id: PartID.ascending(),
1208-
type: "text",
1209-
text: inputText,
1210-
},
1211-
...nonTextParts.map(assign),
1212-
],
1213-
})
1214-
.catch(() => {})
1215+
.prompt(request)
1216+
.catch(() => sync.session.removeOptimisticPrompt(request.sessionID, request.messageID))
12151217
if (editorParts.length > 0) editor.markSelectionSent()
12161218
}
12171219
history.append({
Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
1+
import type { AgentPartInput, FilePartInput, Message, Part, SubtaskPartInput, TextPartInput } from "@opencode-ai/sdk/v2"
2+
import { Binary } from "@opencode-ai/core/util/binary"
3+
4+
export type OptimisticPromptPart = (TextPartInput | FilePartInput | AgentPartInput | SubtaskPartInput) & { id: string }
5+
6+
export function optimisticParts(input: { sessionID: string; messageID: string; parts: OptimisticPromptPart[] }) {
7+
return input.parts.map((part): Part => {
8+
const withIDs = {
9+
...part,
10+
sessionID: input.sessionID,
11+
messageID: input.messageID,
12+
}
13+
if (withIDs.type === "file") return { ...withIDs, url: "" }
14+
return withIDs
15+
})
16+
}
17+
18+
export function mergeFetchedMessages(input: {
19+
currentMessages: Message[]
20+
currentParts: Record<string, Part[] | undefined>
21+
fetched: { info: Message; parts: Part[] }[]
22+
optimisticMessages: ReadonlySet<string>
23+
}) {
24+
const fetchedIDs = new Set(input.fetched.map((message) => message.info.id))
25+
const messages = input.fetched.map((message) => message.info)
26+
const parts = new Map<string, Part[]>()
27+
const resolved = new Set<string>()
28+
29+
for (const message of input.currentMessages) {
30+
if (input.optimisticMessages.has(message.id) && !fetchedIDs.has(message.id)) {
31+
Binary.insert(messages, message, (item) => item.id)
32+
}
33+
}
34+
35+
for (const message of input.fetched) {
36+
if (message.parts.length > 0) {
37+
resolved.add(message.info.id)
38+
parts.set(message.info.id, message.parts)
39+
continue
40+
}
41+
if (input.optimisticMessages.has(message.info.id)) {
42+
const current = input.currentParts[message.info.id]
43+
if (current) parts.set(message.info.id, current)
44+
continue
45+
}
46+
parts.set(message.info.id, message.parts)
47+
}
48+
49+
return { messages, parts, resolved }
50+
}

packages/opencode/src/cli/cmd/tui/context/sync.tsx

Lines changed: 77 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ import * as Log from "@opencode-ai/core/util/log"
3333
import { emptyConsoleState, type ConsoleState } from "@/config/console-state"
3434
import path from "path"
3535
import { aggregateFailures } from "./aggregate-failures"
36+
import { mergeFetchedMessages, optimisticParts, type OptimisticPromptPart } from "./sync-optimistic"
3637

3738
export const { use: useSync, provider: SyncProvider } = createSimpleContext({
3839
name: "Sync",
@@ -114,6 +115,7 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
114115
const [autoaccept] = kv.signal<"none" | "edit">("permission_auto_accept", "edit")
115116

116117
const fullSyncedSessions = new Set<string>()
118+
const optimisticMessages = new Set<string>()
117119

118120
function sessionListQuery(): { scope?: "project"; path?: string } {
119121
if (!kv.get("session_directory_filter_enabled", true)) return { scope: "project" }
@@ -227,6 +229,7 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
227229
break
228230

229231
case "session.deleted": {
232+
for (const message of store.message[event.properties.info.id] ?? []) optimisticMessages.delete(message.id)
230233
const result = Binary.search(store.session, event.properties.info.id, (s) => s.id)
231234
if (result.found) {
232235
setStore(
@@ -298,6 +301,7 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
298301
break
299302
}
300303
case "message.removed": {
304+
optimisticMessages.delete(event.properties.messageID)
301305
const messages = store.message[event.properties.sessionID]
302306
const result = Binary.search(messages, event.properties.messageID, (m) => m.id)
303307
if (result.found) {
@@ -312,6 +316,7 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
312316
break
313317
}
314318
case "message.part.updated": {
319+
optimisticMessages.delete(event.properties.part.messageID)
315320
const parts = store.part[event.properties.part.messageID]
316321
if (!parts) {
317322
setStore("part", event.properties.part.messageID, [event.properties.part])
@@ -526,6 +531,66 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
526531
if (last.role === "user") return "working"
527532
return last.time.completed ? "idle" : "working"
528533
},
534+
addOptimisticPrompt(input: {
535+
sessionID: string
536+
messageID: string
537+
agent: string
538+
model: { providerID: string; modelID: string }
539+
variant?: string
540+
parts: OptimisticPromptPart[]
541+
}) {
542+
optimisticMessages.add(input.messageID)
543+
const messages = store.message[input.sessionID]
544+
const match = messages ? Binary.search(messages, input.messageID, (m) => m.id) : undefined
545+
const info: Message = {
546+
id: input.messageID,
547+
sessionID: input.sessionID,
548+
role: "user",
549+
time: { created: Date.now() },
550+
agent: input.agent,
551+
model: {
552+
providerID: input.model.providerID,
553+
modelID: input.model.modelID,
554+
...(input.variant ? { variant: input.variant } : {}),
555+
},
556+
}
557+
batch(() => {
558+
if (!messages) {
559+
setStore("message", input.sessionID, [info])
560+
} else if (!match?.found) {
561+
setStore(
562+
"message",
563+
input.sessionID,
564+
produce((draft) => {
565+
Binary.insert(draft, info, (message) => message.id)
566+
}),
567+
)
568+
}
569+
setStore("part", input.messageID, reconcile(optimisticParts(input)))
570+
})
571+
},
572+
removeOptimisticPrompt(sessionID: string, messageID: string) {
573+
if (!optimisticMessages.delete(messageID)) return
574+
const messages = store.message[sessionID]
575+
const match = messages ? Binary.search(messages, messageID, (m) => m.id) : undefined
576+
batch(() => {
577+
if (match?.found) {
578+
setStore(
579+
"message",
580+
sessionID,
581+
produce((draft) => {
582+
draft.splice(match.index, 1)
583+
}),
584+
)
585+
}
586+
setStore(
587+
"part",
588+
produce((draft) => {
589+
delete draft[messageID]
590+
}),
591+
)
592+
})
593+
},
529594
async sync(sessionID: string) {
530595
if (fullSyncedSessions.has(sessionID)) return
531596
const [session, messages, todo, diff] = await Promise.all([
@@ -537,15 +602,22 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
537602
setStore(
538603
produce((draft) => {
539604
const match = Binary.search(draft.session, sessionID, (s) => s.id)
605+
const merged = mergeFetchedMessages({
606+
currentMessages: draft.message[sessionID] ?? [],
607+
currentParts: draft.part,
608+
fetched: messages.data ?? [],
609+
optimisticMessages,
610+
})
540611
if (match.found) draft.session[match.index] = session.data!
541612
if (!match.found) draft.session.splice(match.index, 0, session.data!)
542613
draft.todo[sessionID] = todo.data ?? []
543-
const infos: (typeof draft.message)[string] = []
544-
for (const message of messages.data ?? []) {
545-
infos.push(message.info)
546-
draft.part[message.info.id] = message.parts
614+
draft.message[sessionID] = merged.messages
615+
for (const messageID of merged.resolved) {
616+
optimisticMessages.delete(messageID)
617+
}
618+
for (const [messageID, parts] of merged.parts) {
619+
draft.part[messageID] = parts
547620
}
548-
draft.message[sessionID] = infos
549621
draft.session_diff[sessionID] = diff.data ?? []
550622
}),
551623
)
Lines changed: 92 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,92 @@
1+
import { describe, expect, test } from "bun:test"
2+
import type { Message, Part } from "@opencode-ai/sdk/v2"
3+
import { mergeFetchedMessages, optimisticParts } from "@/cli/cmd/tui/context/sync-optimistic"
4+
5+
function user(id: string): Message {
6+
return {
7+
id,
8+
sessionID: "ses_test",
9+
role: "user",
10+
time: { created: 1 },
11+
agent: "build",
12+
model: { providerID: "test", modelID: "model" },
13+
}
14+
}
15+
16+
function text(messageID: string, text: string): Part {
17+
return {
18+
id: `part_${messageID}`,
19+
sessionID: "ses_test",
20+
messageID,
21+
type: "text",
22+
text,
23+
}
24+
}
25+
26+
describe("TUI optimistic prompt sync", () => {
27+
test("keeps an optimistic message while session sync has not fetched it yet", () => {
28+
const merged = mergeFetchedMessages({
29+
currentMessages: [user("msg_2")],
30+
currentParts: { msg_2: [text("msg_2", "optimistic")] },
31+
fetched: [{ info: user("msg_1"), parts: [text("msg_1", "persisted")] }],
32+
optimisticMessages: new Set(["msg_2"]),
33+
})
34+
35+
expect(merged.messages.map((message) => message.id)).toEqual(["msg_1", "msg_2"])
36+
expect(merged.parts.get("msg_1")?.map((part) => (part.type === "text" ? part.text : ""))).toEqual(["persisted"])
37+
expect(merged.resolved.has("msg_2")).toBe(false)
38+
})
39+
40+
test("preserves optimistic parts when sync fetches the message before its parts", () => {
41+
const merged = mergeFetchedMessages({
42+
currentMessages: [user("msg_1")],
43+
currentParts: { msg_1: [text("msg_1", "optimistic")] },
44+
fetched: [{ info: user("msg_1"), parts: [] }],
45+
optimisticMessages: new Set(["msg_1"]),
46+
})
47+
48+
expect(merged.messages.map((message) => message.id)).toEqual(["msg_1"])
49+
expect(merged.parts.get("msg_1")?.map((part) => (part.type === "text" ? part.text : ""))).toEqual(["optimistic"])
50+
expect(merged.resolved.has("msg_1")).toBe(false)
51+
})
52+
53+
test("replaces optimistic parts once real fetched parts arrive", () => {
54+
const merged = mergeFetchedMessages({
55+
currentMessages: [user("msg_1")],
56+
currentParts: { msg_1: [text("msg_1", "optimistic")] },
57+
fetched: [{ info: user("msg_1"), parts: [text("msg_1", "persisted")] }],
58+
optimisticMessages: new Set(["msg_1"]),
59+
})
60+
61+
expect(merged.parts.get("msg_1")?.map((part) => (part.type === "text" ? part.text : ""))).toEqual(["persisted"])
62+
expect(merged.resolved.has("msg_1")).toBe(true)
63+
})
64+
65+
test("strips file URLs from optimistic render parts", () => {
66+
const parts = optimisticParts({
67+
sessionID: "ses_test",
68+
messageID: "msg_1",
69+
parts: [
70+
{
71+
id: "part_file",
72+
type: "file",
73+
mime: "image/png",
74+
filename: "image.png",
75+
url: "data:image/png;base64,large",
76+
},
77+
],
78+
})
79+
80+
expect(parts).toEqual([
81+
{
82+
id: "part_file",
83+
sessionID: "ses_test",
84+
messageID: "msg_1",
85+
type: "file",
86+
mime: "image/png",
87+
filename: "image.png",
88+
url: "",
89+
},
90+
])
91+
})
92+
})

0 commit comments

Comments
 (0)