Skip to content

Commit 399f7e1

Browse files
Apply PR #26387: tui: optimistically render submitted prompts
2 parents ec5b33d + 1462f9c commit 399f7e1

4 files changed

Lines changed: 241 additions & 19 deletions

File tree

packages/opencode/src/cli/cmd/tui/component/prompt/index.tsx

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1098,25 +1098,27 @@ export function Prompt(props: PromptProps) {
10981098
})
10991099
} else {
11001100
move.startSubmit()
1101+
const parts = [
1102+
...editorParts,
1103+
{
1104+
id: PartID.ascending(),
1105+
type: "text" as const,
1106+
text: inputText,
1107+
},
1108+
...nonTextParts.map(assign),
1109+
]
1110+
const request = {
1111+
sessionID,
1112+
messageID,
1113+
agent: agent.name,
1114+
model: selectedModel,
1115+
variant,
1116+
parts,
1117+
}
1118+
sync.session.addOptimisticPrompt(request)
11011119
sdk.client.session
1102-
.prompt({
1103-
sessionID,
1104-
...selectedModel,
1105-
messageID,
1106-
agent: agent.name,
1107-
model: selectedModel,
1108-
variant,
1109-
parts: [
1110-
...editorParts,
1111-
{
1112-
id: PartID.ascending(),
1113-
type: "text",
1114-
text: inputText,
1115-
},
1116-
...nonTextParts.map(assign),
1117-
],
1118-
})
1119-
.catch(() => {})
1120+
.prompt(request)
1121+
.catch(() => sync.session.removeOptimisticPrompt(request.sessionID, request.messageID))
11201122
if (editorParts.length > 0) editor.markSelectionSent()
11211123
}
11221124
history.append({
Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
1+
import type { AgentPartInput, FilePartInput, Message, Part, SubtaskPartInput, TextPartInput } from "@opencode-ai/sdk/v2"
2+
import { Binary } from "@opencode-ai/core/util/binary"
3+
4+
export type OptimisticPromptPart = (TextPartInput | FilePartInput | AgentPartInput | SubtaskPartInput) & { id: string }
5+
6+
export function optimisticParts(input: { sessionID: string; messageID: string; parts: OptimisticPromptPart[] }) {
7+
return input.parts.map((part): Part => {
8+
const withIDs = {
9+
...part,
10+
sessionID: input.sessionID,
11+
messageID: input.messageID,
12+
}
13+
if (withIDs.type === "file") return { ...withIDs, url: "" }
14+
return withIDs
15+
})
16+
}
17+
18+
export function mergeFetchedMessages(input: {
19+
currentMessages: Message[]
20+
currentParts: Record<string, Part[] | undefined>
21+
fetched: { info: Message; parts: Part[] }[]
22+
optimisticMessages: ReadonlySet<string>
23+
}) {
24+
const fetchedIDs = new Set(input.fetched.map((message) => message.info.id))
25+
const messages = input.fetched.map((message) => message.info)
26+
const parts = new Map<string, Part[]>()
27+
const resolved = new Set<string>()
28+
29+
for (const message of input.currentMessages) {
30+
if (input.optimisticMessages.has(message.id) && !fetchedIDs.has(message.id)) {
31+
Binary.insert(messages, message, (item) => item.id)
32+
}
33+
}
34+
35+
for (const message of input.fetched) {
36+
if (message.parts.length > 0) {
37+
resolved.add(message.info.id)
38+
parts.set(message.info.id, message.parts)
39+
continue
40+
}
41+
if (input.optimisticMessages.has(message.info.id)) {
42+
const current = input.currentParts[message.info.id]
43+
if (current) parts.set(message.info.id, current)
44+
continue
45+
}
46+
parts.set(message.info.id, message.parts)
47+
}
48+
49+
return { messages, parts, resolved }
50+
}

packages/opencode/src/cli/cmd/tui/context/sync.tsx

Lines changed: 79 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ import { emptyConsoleState, type ConsoleState } from "@opencode-ai/core/v1/confi
3333
import path from "path"
3434
import { useKV } from "./kv"
3535
import { aggregateFailures } from "./aggregate-failures"
36+
import { optimisticParts, type OptimisticPromptPart } from "./sync-optimistic"
3637

3738
export const { use: useSync, provider: SyncProvider } = createSimpleContext({
3839
name: "Sync",
@@ -122,6 +123,7 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
122123
const touchPart = (sessionID: string, partID: string) => {
123124
hydratingSessions.get(sessionID)?.parts.add(partID)
124125
}
126+
const optimisticMessages = new Set<string>()
125127

126128
function sessionListQuery(): { scope?: "project"; path?: string } {
127129
if (!kv.get("session_directory_filter_enabled", true)) return { scope: "project" }
@@ -235,6 +237,7 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
235237
break
236238

237239
case "session.deleted": {
240+
for (const message of store.message[event.properties.info.id] ?? []) optimisticMessages.delete(message.id)
238241
const result = Binary.search(store.session, event.properties.info.id, (s) => s.id)
239242
if (result.found) {
240243
setStore(
@@ -324,6 +327,7 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
324327
}
325328
case "message.removed": {
326329
touchMessage(event.properties.sessionID, event.properties.messageID)
330+
optimisticMessages.delete(event.properties.messageID)
327331
const messages = store.message[event.properties.sessionID]
328332
const result = Binary.search(messages, event.properties.messageID, (m) => m.id)
329333
if (result.found) {
@@ -339,6 +343,7 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
339343
}
340344
case "message.part.updated": {
341345
touchPart(event.properties.part.sessionID, event.properties.part.id)
346+
optimisticMessages.delete(event.properties.part.messageID)
342347
const parts = store.part[event.properties.part.messageID]
343348
if (!parts) {
344349
setStore("part", event.properties.part.messageID, [event.properties.part])
@@ -555,6 +560,66 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
555560
if (last.role === "user") return "working"
556561
return last.time.completed ? "idle" : "working"
557562
},
563+
addOptimisticPrompt(input: {
564+
sessionID: string
565+
messageID: string
566+
agent: string
567+
model: { providerID: string; modelID: string }
568+
variant?: string
569+
parts: OptimisticPromptPart[]
570+
}) {
571+
optimisticMessages.add(input.messageID)
572+
const messages = store.message[input.sessionID]
573+
const match = messages ? Binary.search(messages, input.messageID, (m) => m.id) : undefined
574+
const info: Message = {
575+
id: input.messageID,
576+
sessionID: input.sessionID,
577+
role: "user",
578+
time: { created: Date.now() },
579+
agent: input.agent,
580+
model: {
581+
providerID: input.model.providerID,
582+
modelID: input.model.modelID,
583+
...(input.variant ? { variant: input.variant } : {}),
584+
},
585+
}
586+
batch(() => {
587+
if (!messages) {
588+
setStore("message", input.sessionID, [info])
589+
} else if (!match?.found) {
590+
setStore(
591+
"message",
592+
input.sessionID,
593+
produce((draft) => {
594+
Binary.insert(draft, info, (message) => message.id)
595+
}),
596+
)
597+
}
598+
setStore("part", input.messageID, reconcile(optimisticParts(input)))
599+
})
600+
},
601+
removeOptimisticPrompt(sessionID: string, messageID: string) {
602+
if (!optimisticMessages.delete(messageID)) return
603+
const messages = store.message[sessionID]
604+
const match = messages ? Binary.search(messages, messageID, (m) => m.id) : undefined
605+
batch(() => {
606+
if (match?.found) {
607+
setStore(
608+
"message",
609+
sessionID,
610+
produce((draft) => {
611+
draft.splice(match.index, 1)
612+
}),
613+
)
614+
}
615+
setStore(
616+
"part",
617+
produce((draft) => {
618+
delete draft[messageID]
619+
}),
620+
)
621+
})
622+
},
558623
async sync(sessionID: string) {
559624
if (fullSyncedSessions.has(sessionID)) return
560625
const syncing = syncingSessions.get(sessionID)
@@ -582,18 +647,28 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
582647
})
583648
infos.push(
584649
...currentMessages.filter(
585-
(message) => tracker.messages.has(message.id) && !infos.some((item) => item.id === message.id),
650+
(message) =>
651+
(tracker.messages.has(message.id) || optimisticMessages.has(message.id)) &&
652+
!infos.some((item) => item.id === message.id),
586653
),
587654
)
588655
const removed = infos.slice(0, -100)
589656
const visible = infos.slice(-100)
590657
const visibleIDs = new Set(visible.map((message) => message.id))
658+
const resolvedOptimisticMessages = new Set<string>()
591659
for (const message of messages.data ?? []) {
592660
if (!visibleIDs.has(message.info.id)) {
593661
delete draft.part[message.info.id]
594662
continue
595663
}
596664
const currentParts = draft.part[message.info.id] ?? []
665+
if (optimisticMessages.has(message.info.id) && message.parts.length > 0) {
666+
resolvedOptimisticMessages.add(message.info.id)
667+
}
668+
if (optimisticMessages.has(message.info.id) && message.parts.length === 0) {
669+
draft.part[message.info.id] = currentParts
670+
continue
671+
}
597672
const parts = message.parts.flatMap((part) => {
598673
const current = currentParts.find((item) => item.id === part.id)
599674
if (tracker.parts.has(part.id)) return current ? [current] : []
@@ -617,6 +692,9 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
617692
}
618693
for (const message of removed) delete draft.part[message.id]
619694
draft.message[sessionID] = visible
695+
for (const messageID of resolvedOptimisticMessages) {
696+
optimisticMessages.delete(messageID)
697+
}
620698
draft.session_diff[sessionID] = diff.data ?? []
621699
}),
622700
)
Lines changed: 92 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,92 @@
1+
import { describe, expect, test } from "bun:test"
2+
import type { Message, Part } from "@opencode-ai/sdk/v2"
3+
import { mergeFetchedMessages, optimisticParts } from "@/cli/cmd/tui/context/sync-optimistic"
4+
5+
function user(id: string): Message {
6+
return {
7+
id,
8+
sessionID: "ses_test",
9+
role: "user",
10+
time: { created: 1 },
11+
agent: "build",
12+
model: { providerID: "test", modelID: "model" },
13+
}
14+
}
15+
16+
function text(messageID: string, text: string): Part {
17+
return {
18+
id: `part_${messageID}`,
19+
sessionID: "ses_test",
20+
messageID,
21+
type: "text",
22+
text,
23+
}
24+
}
25+
26+
describe("TUI optimistic prompt sync", () => {
27+
test("keeps an optimistic message while session sync has not fetched it yet", () => {
28+
const merged = mergeFetchedMessages({
29+
currentMessages: [user("msg_2")],
30+
currentParts: { msg_2: [text("msg_2", "optimistic")] },
31+
fetched: [{ info: user("msg_1"), parts: [text("msg_1", "persisted")] }],
32+
optimisticMessages: new Set(["msg_2"]),
33+
})
34+
35+
expect(merged.messages.map((message) => message.id)).toEqual(["msg_1", "msg_2"])
36+
expect(merged.parts.get("msg_1")?.map((part) => (part.type === "text" ? part.text : ""))).toEqual(["persisted"])
37+
expect(merged.resolved.has("msg_2")).toBe(false)
38+
})
39+
40+
test("preserves optimistic parts when sync fetches the message before its parts", () => {
41+
const merged = mergeFetchedMessages({
42+
currentMessages: [user("msg_1")],
43+
currentParts: { msg_1: [text("msg_1", "optimistic")] },
44+
fetched: [{ info: user("msg_1"), parts: [] }],
45+
optimisticMessages: new Set(["msg_1"]),
46+
})
47+
48+
expect(merged.messages.map((message) => message.id)).toEqual(["msg_1"])
49+
expect(merged.parts.get("msg_1")?.map((part) => (part.type === "text" ? part.text : ""))).toEqual(["optimistic"])
50+
expect(merged.resolved.has("msg_1")).toBe(false)
51+
})
52+
53+
test("replaces optimistic parts once real fetched parts arrive", () => {
54+
const merged = mergeFetchedMessages({
55+
currentMessages: [user("msg_1")],
56+
currentParts: { msg_1: [text("msg_1", "optimistic")] },
57+
fetched: [{ info: user("msg_1"), parts: [text("msg_1", "persisted")] }],
58+
optimisticMessages: new Set(["msg_1"]),
59+
})
60+
61+
expect(merged.parts.get("msg_1")?.map((part) => (part.type === "text" ? part.text : ""))).toEqual(["persisted"])
62+
expect(merged.resolved.has("msg_1")).toBe(true)
63+
})
64+
65+
test("strips file URLs from optimistic render parts", () => {
66+
const parts = optimisticParts({
67+
sessionID: "ses_test",
68+
messageID: "msg_1",
69+
parts: [
70+
{
71+
id: "part_file",
72+
type: "file",
73+
mime: "image/png",
74+
filename: "image.png",
75+
url: "data:image/png;base64,large",
76+
},
77+
],
78+
})
79+
80+
expect(parts).toEqual([
81+
{
82+
id: "part_file",
83+
sessionID: "ses_test",
84+
messageID: "msg_1",
85+
type: "file",
86+
mime: "image/png",
87+
filename: "image.png",
88+
url: "",
89+
},
90+
])
91+
})
92+
})

0 commit comments

Comments
 (0)