Clean up post-Hono references (#26903)

Author: kitlangton

bun.lock

@@ -20,12 +20,10 @@
     "@ai-sdk/anthropic": "3.0.64",
     "@ai-sdk/openai": "3.0.48",
     "@ai-sdk/openai-compatible": "2.0.37",
-    "@hono/zod-validator": "catalog:",
     "@opencode-ai/console-core": "workspace:*",
     "@opencode-ai/console-resource": "workspace:*",
     "@openauthjs/openauth": "0.0.0-20250322224806",
     "ai": "catalog:",
-    "hono": "catalog:",
     "zod": "catalog:"
   }
 }

packages/console/function/package.json

@@ -23,8 +23,9 @@ contracts.
 - Some services already use `Schema.TaggedErrorClass`, for example `Account`,
   `Auth`, `Permission`, `Question`, `Installation`, and parts of
   `Workspace`.
-- Legacy Hono error handling recognizes `NamedError`, `Session.BusyError`, and a
-  few name-based cases, then emits the legacy `{ name, data }` JSON body.
+- The temporary HttpApi compatibility middleware recognizes `NamedError`,
+  `Session.BusyError`, and a few name-based cases, then emits the legacy
+  `{ name, data }` JSON body.
 - Effect `HttpApi` only knows how to encode errors that are declared on the
   endpoint, group, or middleware. Undeclared expected errors become defects and
   eventually fall through to generic HTTP handling.
@@ -127,7 +128,7 @@ Create an HttpApi-local error module, likely
 That module should provide:
 
 - Legacy-compatible public schemas for `{ name, data }` error bodies that must
-  remain SDK-compatible during the Hono migration.
+  remain SDK-compatible while route groups declare typed errors.
 - Small constructors or mapping helpers for common API errors such as not found,
   bad request, conflict, and unknown internal errors.
 - Route-group-specific adapters only when they encode domain-specific public
@@ -173,7 +174,7 @@ Add the `httpapi/errors.ts` module before converting route groups.
 - Define a legacy `{ name, data }` body helper for SDK-compatible errors.
 - Define `UnknownError` for generic internal failures with a safe public message.
 - Define `BadRequestError` and `NotFoundError` equivalents only if the actual
-  wire body must match the legacy Hono SDK surface.
+  wire body must match the existing SDK surface.
 - Put the HTTP status on the public schema with `HttpApiSchema.status(...)` or
   `{ httpApiStatus: code }`; do not keep a separate name-to-status table.
 - Keep conversion helpers pure and small. They should not inspect `Cause` or
@@ -238,7 +239,7 @@ Suggested route order:
 2. `experimental` worktree mutations.
 3. `provider` auth and model selection errors.
 4. `mcp` OAuth and connection errors.
-5. Remaining route groups as Hono deletion work progresses.
+5. Remaining route groups as typed error contracts are declared.
 
 ### 6. Remove Defect Recovery
 
@@ -286,8 +287,8 @@ For HttpApi conversions:
   errors.
 - Add a regression test that the temporary middleware is no longer needed for the
   migrated route.
-- Keep bridge/parity tests aligned with legacy Hono behavior until Hono is
-  deleted or the SDK contract intentionally changes.
+- Keep compatibility tests aligned with the existing SDK contract until the
+  public error shape intentionally changes.
 
 ## Verification Commands
 

packages/opencode/specs/effect/errors.md

@@ -39,26 +39,19 @@ This eliminates multiple `runPromise` round-trips and lets handlers compose natu
 
 ## Current route files
 
-Current instance route files live under `src/server/routes/instance`.
-
-Files that are already mostly on the intended service-yielding shape:
-
-- [x] `server/routes/instance/question.ts` — handlers yield `Question.Service`
-- [x] `server/routes/instance/provider.ts` — handlers yield `Provider.Service`, `ProviderAuth.Service`, and `Config.Service`
-- [x] `server/routes/instance/permission.ts` — handlers yield `Permission.Service`
-- [x] `server/routes/instance/mcp.ts` — handlers mostly yield `MCP.Service`
-- [x] `server/routes/instance/pty.ts` — handlers yield `Pty.Service`
+Current instance route files live under `src/server/routes/instance/httpapi`.
+Most handlers already yield stable services at route-layer construction and then
+close over those services in endpoint implementations.
 
 Files still worth tracking here:
 
-- [ ] `server/routes/instance/session.ts` — still the heaviest mixed file; many handlers are composed, but the file still mixes patterns and has direct `Bus.publish(...)` / `Session.list(...)` usage
-- [ ] `server/routes/instance/index.ts` — mostly converted, but still has direct `Instance.dispose()` / `Instance.*` reads for `/instance/dispose` and `/path`
-- [ ] `server/routes/instance/file.ts` — most handlers yield services, but `/find` still passes `Instance.directory` directly into ripgrep and `/find/symbol` is still stubbed
-- [ ] `server/routes/instance/experimental.ts` — mixed state; many handlers are composed, but some still rely on `runRequest(...)` or direct `Instance.project` reads
-- [ ] `server/routes/instance/middleware.ts` — still enters the instance via `Instance.provide(...)`
-- [ ] `server/routes/global.ts` — still uses `Instance.disposeAll()` and remains partly outside the fully-composed style
+- [ ] `handlers/session.ts` — still the heaviest mixed file; some paths keep compatibility translations and direct event publication
+- [ ] `handlers/experimental.ts` — mixed state; some handlers still rely on request-local context reads
+- [ ] `middleware/*` — still contains compatibility policy for auth, compression, errors, instance context, and workspace routing
+- [ ] `public.ts` — still owns SDK/OpenAPI compatibility translation shims
+- [ ] raw route modules — WebSocket and catch-all routes should stay explicit and avoid rebuilding stable layers per request
 
 ## Notes
 
-- Route conversion is now less about facade removal and more about removing the remaining direct `Instance.*` reads, `Instance.provide(...)` boundaries, and small Promise-style bridges inside route files.
-- `jsonRequest(...)` / `runRequest(...)` already provide a good intermediate shape for many handlers. The remaining cleanup is mostly consistency work in the heavier files.
+- Route conversion is now less about backend migration and more about removing the remaining direct `Instance.*` reads, request-local service plumbing, and OpenAPI compatibility shims.
+- Prefer route-layer service capture over rebuilding or providing stable layers inside individual handlers.

packages/opencode/specs/effect/routes.md

@@ -305,38 +305,18 @@ emitted JSON Schema must stay byte-identical.
 
 ### HTTP route boundaries
 
-Every file in `src/server/routes/` uses hono-openapi with zod validators for
-route inputs/outputs. Migrating these individually is the last step; most
-will switch to `.zod` derived from the Schema-migrated domain types above,
-which means touching them is largely mechanical once the domain side is
-done.
-
-- [ ] `src/server/error.ts`
-- [x] `src/server/event.ts`
-- [x] `src/server/projectors.ts`
-- [ ] `src/server/routes/control/index.ts`
-- [ ] `src/server/routes/control/workspace.ts`
-- [ ] `src/server/routes/global.ts`
-- [ ] `src/server/routes/instance/index.ts`
-- [ ] `src/server/routes/instance/config.ts`
-- [ ] `src/server/routes/instance/event.ts`
-- [ ] `src/server/routes/instance/experimental.ts`
-- [ ] `src/server/routes/instance/file.ts`
-- [ ] `src/server/routes/instance/mcp.ts`
-- [ ] `src/server/routes/instance/permission.ts`
-- [ ] `src/server/routes/instance/project.ts`
-- [ ] `src/server/routes/instance/provider.ts`
-- [ ] `src/server/routes/instance/pty.ts`
-- [ ] `src/server/routes/instance/question.ts`
-- [ ] `src/server/routes/instance/session.ts`
-- [ ] `src/server/routes/instance/sync.ts`
-- [ ] `src/server/routes/instance/tui.ts`
-
-The bigger prize for this group is the `@effect/platform` HTTP migration
-described in `specs/effect/http-api.md`. Once that lands, every one of
-these files changes shape entirely (`HttpApi.endpoint(...)` and friends),
-so the Schema-first domain types become a prerequisite rather than a
-sibling task.
+The server route tree now lives under `src/server/routes/instance/httpapi` and
+uses Effect HttpApi contracts for request and response schemas. Remaining schema
+work is no longer a Hono route migration; it is compatibility cleanup around
+derived `.zod` statics, OpenAPI translation shims, and route groups that still
+need explicit SDK-visible error contracts.
+
+Good follow-up targets:
+
+- shrink `public.ts` legacy OpenAPI translation shims one SDK-compatible slice at a time
+- replace production `.zod.safeParse(...)` call sites with Effect Schema decoders
+- remove derived `.zod` statics after their production consumers are gone
+- declare route-group errors directly instead of relying on compatibility middleware
 
 ### Everything else