Skip to content

Commit 9b66590

Browse files
committed
fix(core): keep fff include no-match results
1 parent 75997b2 commit 9b66590

2 files changed

Lines changed: 14 additions & 2 deletions

File tree

packages/core/src/filesystem/search.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -413,8 +413,6 @@ export const layer: Layer.Layer<Service, never, FSUtil.Service | Ripgrep.Service
413413
const rows: Item[] = fffGrep.value.items.map(item)
414414
const regexFallbackError = fffGrep.value.regexFallbackError
415415

416-
if (!rows.length && input.glob?.length) return yield* rip(input)
417-
418416
remember(state, dir, input.pattern, Array.from(new Set(rows.map((row) => path.join(dir, row.path.text)))))
419417

420418
return {

packages/core/test/filesystem/search.test.ts

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,20 @@ describe("file.search", () => {
109109
}),
110110
)
111111

112+
it.live("keeps fff grep include no-match results", () =>
113+
Effect.gen(function* () {
114+
expect(Fff.available()).toBe(true)
115+
const dir = yield* tmpdir()
116+
yield* write(path.join(dir, "src", "match.ts"), "needle\n")
117+
118+
const search = yield* Search.Service
119+
const result = yield* search.search({ cwd: dir, pattern: "missing", glob: ["*.ts"], limit: 10 })
120+
121+
expect(result.engine).toBe("fff")
122+
expect(result.items).toEqual([])
123+
}),
124+
)
125+
112126
it.live("post-filters fff glob matches", () =>
113127
Effect.gen(function* () {
114128
expect(Fff.available()).toBe(true)

0 commit comments

Comments
 (0)