Skip to content

Commit abb1ee6

Browse files
authored
docs(test): add Effect migration orchestration notes (#26963)
1 parent c400357 commit abb1ee6

1 file changed

Lines changed: 10 additions & 1 deletion

File tree

packages/opencode/test/EFFECT_TEST_MIGRATION.md

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,11 +200,20 @@ Use this as a migration queue. Each checkbox should be safe for one agent or one
200200

201201
Parallelization notes:
202202

203-
- The first four items are mostly independent and good for parallel agents.
203+
- The first four items are mostly independent and good for separate worktrees.
204204
- `provider.test.ts`, `tool/edit.test.ts`, and `config.test.ts` should be split by cluster so agents do not edit the same file concurrently.
205205
- Any new fake boundary layer under `test/fake/*` should be small and independently useful. Do not add a fake just for one assertion unless it removes a real external dependency.
206206
- Do not combine assertion-helper design with file migrations. First collect repeated shapes, then add helpers in a separate pass.
207207

208+
Orchestration rules:
209+
210+
- Prefer supervised foreground agents for implementation. Background agents are acceptable for research-only surveys, but code migrations need a returned diff, focused test output, and local commit before moving on.
211+
- Create one worktree per claim and verify the branch/worktree path before edits. A status check should include `git status --short --branch` from the claimed worktree.
212+
- After an agent reports completion, the coordinator must independently inspect `git status`, run the focused test, run `bun typecheck`, and review the diff before pushing.
213+
- If an agent edits the wrong worktree, move the patch deliberately with `git diff` / `git apply`, then clean the accidental worktree before opening a PR.
214+
- Keep dependency setup boring. Prefer reusing existing installed dependencies via worktrees or symlinks over running a fresh `bun install` in a temporary path unless the native build path is known to work.
215+
- Do not delete worktrees with unpushed commits or uncommitted changes. Once a migration PR branch is pushed and clean, the local worktree can be removed while leaving the branch on the fork.
216+
208217
## Effectified Test Rough Edges
209218

210219
Track patterns that are technically Effect-native but still too noisy. These should become a second cleanup pass after the Promise-land migration is underway.

0 commit comments

Comments
 (0)