Skip to content

Commit e377ca8

Browse files
Apply PR #26387: tui: optimistically render submitted prompts
2 parents f9f2ad5 + ecb6457 commit e377ca8

4 files changed

Lines changed: 240 additions & 21 deletions

File tree

packages/opencode/src/cli/cmd/tui/component/prompt/index.tsx

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1186,25 +1186,27 @@ export function Prompt(props: PromptProps) {
11861186
})),
11871187
})
11881188
} else {
1189+
const parts = [
1190+
...editorParts,
1191+
{
1192+
id: PartID.ascending(),
1193+
type: "text" as const,
1194+
text: inputText,
1195+
},
1196+
...nonTextParts.map(assign),
1197+
]
1198+
const request = {
1199+
sessionID,
1200+
messageID,
1201+
agent: agent.name,
1202+
model: selectedModel,
1203+
variant,
1204+
parts,
1205+
}
1206+
sync.session.addOptimisticPrompt(request)
11891207
sdk.client.session
1190-
.prompt({
1191-
sessionID,
1192-
...selectedModel,
1193-
messageID,
1194-
agent: agent.name,
1195-
model: selectedModel,
1196-
variant,
1197-
parts: [
1198-
...editorParts,
1199-
{
1200-
id: PartID.ascending(),
1201-
type: "text",
1202-
text: inputText,
1203-
},
1204-
...nonTextParts.map(assign),
1205-
],
1206-
})
1207-
.catch(() => {})
1208+
.prompt(request)
1209+
.catch(() => sync.session.removeOptimisticPrompt(request.sessionID, request.messageID))
12081210
if (editorParts.length > 0) editor.markSelectionSent()
12091211
}
12101212
history.append({
Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
1+
import type { AgentPartInput, FilePartInput, Message, Part, SubtaskPartInput, TextPartInput } from "@opencode-ai/sdk/v2"
2+
import { Binary } from "@opencode-ai/core/util/binary"
3+
4+
export type OptimisticPromptPart = (TextPartInput | FilePartInput | AgentPartInput | SubtaskPartInput) & { id: string }
5+
6+
export function optimisticParts(input: { sessionID: string; messageID: string; parts: OptimisticPromptPart[] }) {
7+
return input.parts.map((part): Part => {
8+
const withIDs = {
9+
...part,
10+
sessionID: input.sessionID,
11+
messageID: input.messageID,
12+
}
13+
if (withIDs.type === "file") return { ...withIDs, url: "" }
14+
return withIDs
15+
})
16+
}
17+
18+
export function mergeFetchedMessages(input: {
19+
currentMessages: Message[]
20+
currentParts: Record<string, Part[] | undefined>
21+
fetched: { info: Message; parts: Part[] }[]
22+
optimisticMessages: ReadonlySet<string>
23+
}) {
24+
const fetchedIDs = new Set(input.fetched.map((message) => message.info.id))
25+
const messages = input.fetched.map((message) => message.info)
26+
const parts = new Map<string, Part[]>()
27+
const resolved = new Set<string>()
28+
29+
for (const message of input.currentMessages) {
30+
if (input.optimisticMessages.has(message.id) && !fetchedIDs.has(message.id)) {
31+
Binary.insert(messages, message, (item) => item.id)
32+
}
33+
}
34+
35+
for (const message of input.fetched) {
36+
if (message.parts.length > 0) {
37+
resolved.add(message.info.id)
38+
parts.set(message.info.id, message.parts)
39+
continue
40+
}
41+
if (input.optimisticMessages.has(message.info.id)) {
42+
const current = input.currentParts[message.info.id]
43+
if (current) parts.set(message.info.id, current)
44+
continue
45+
}
46+
parts.set(message.info.id, message.parts)
47+
}
48+
49+
return { messages, parts, resolved }
50+
}

packages/opencode/src/cli/cmd/tui/context/sync.tsx

Lines changed: 78 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ import * as Log from "@opencode-ai/core/util/log"
3232
import { emptyConsoleState, type ConsoleState } from "@/config/console-state"
3333
import path from "path"
3434
import { useKV } from "./kv"
35+
import { mergeFetchedMessages, optimisticParts, type OptimisticPromptPart } from "./sync-optimistic"
3536

3637
export const { use: useSync, provider: SyncProvider } = createSimpleContext({
3738
name: "Sync",
@@ -113,6 +114,7 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
113114
const [autoaccept] = kv.signal<"none" | "edit">("permission_auto_accept", "edit")
114115

115116
const fullSyncedSessions = new Set<string>()
117+
const optimisticMessages = new Set<string>()
116118
let syncedWorkspace = project.workspace.current()
117119

118120
function sessionListQuery(): { scope?: "project"; path?: string } {
@@ -227,6 +229,7 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
227229
break
228230

229231
case "session.deleted": {
232+
for (const message of store.message[event.properties.info.id] ?? []) optimisticMessages.delete(message.id)
230233
const result = Binary.search(store.session, event.properties.info.id, (s) => s.id)
231234
if (result.found) {
232235
setStore(
@@ -298,6 +301,7 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
298301
break
299302
}
300303
case "message.removed": {
304+
optimisticMessages.delete(event.properties.messageID)
301305
const messages = store.message[event.properties.sessionID]
302306
const result = Binary.search(messages, event.properties.messageID, (m) => m.id)
303307
if (result.found) {
@@ -312,6 +316,7 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
312316
break
313317
}
314318
case "message.part.updated": {
319+
optimisticMessages.delete(event.properties.part.messageID)
315320
const parts = store.part[event.properties.part.messageID]
316321
if (!parts) {
317322
setStore("part", event.properties.part.messageID, [event.properties.part])
@@ -385,6 +390,7 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
385390
const workspace = project.workspace.current()
386391
if (workspace !== syncedWorkspace) {
387392
fullSyncedSessions.clear()
393+
optimisticMessages.clear()
388394
syncedWorkspace = workspace
389395
}
390396
const projectPromise = project.sync()
@@ -520,6 +526,66 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
520526
if (last.role === "user") return "working"
521527
return last.time.completed ? "idle" : "working"
522528
},
529+
addOptimisticPrompt(input: {
530+
sessionID: string
531+
messageID: string
532+
agent: string
533+
model: { providerID: string; modelID: string }
534+
variant?: string
535+
parts: OptimisticPromptPart[]
536+
}) {
537+
optimisticMessages.add(input.messageID)
538+
const messages = store.message[input.sessionID]
539+
const match = messages ? Binary.search(messages, input.messageID, (m) => m.id) : undefined
540+
const info: Message = {
541+
id: input.messageID,
542+
sessionID: input.sessionID,
543+
role: "user",
544+
time: { created: Date.now() },
545+
agent: input.agent,
546+
model: {
547+
providerID: input.model.providerID,
548+
modelID: input.model.modelID,
549+
...(input.variant ? { variant: input.variant } : {}),
550+
},
551+
}
552+
batch(() => {
553+
if (!messages) {
554+
setStore("message", input.sessionID, [info])
555+
} else if (!match?.found) {
556+
setStore(
557+
"message",
558+
input.sessionID,
559+
produce((draft) => {
560+
Binary.insert(draft, info, (message) => message.id)
561+
}),
562+
)
563+
}
564+
setStore("part", input.messageID, reconcile(optimisticParts(input)))
565+
})
566+
},
567+
removeOptimisticPrompt(sessionID: string, messageID: string) {
568+
if (!optimisticMessages.delete(messageID)) return
569+
const messages = store.message[sessionID]
570+
const match = messages ? Binary.search(messages, messageID, (m) => m.id) : undefined
571+
batch(() => {
572+
if (match?.found) {
573+
setStore(
574+
"message",
575+
sessionID,
576+
produce((draft) => {
577+
draft.splice(match.index, 1)
578+
}),
579+
)
580+
}
581+
setStore(
582+
"part",
583+
produce((draft) => {
584+
delete draft[messageID]
585+
}),
586+
)
587+
})
588+
},
523589
async sync(sessionID: string) {
524590
if (fullSyncedSessions.has(sessionID)) return
525591
const [session, messages, todo, diff] = await Promise.all([
@@ -531,12 +597,21 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
531597
setStore(
532598
produce((draft) => {
533599
const match = Binary.search(draft.session, sessionID, (s) => s.id)
600+
const merged = mergeFetchedMessages({
601+
currentMessages: draft.message[sessionID] ?? [],
602+
currentParts: draft.part,
603+
fetched: messages.data!,
604+
optimisticMessages,
605+
})
534606
if (match.found) draft.session[match.index] = session.data!
535607
if (!match.found) draft.session.splice(match.index, 0, session.data!)
536608
draft.todo[sessionID] = todo.data ?? []
537-
draft.message[sessionID] = messages.data!.map((x) => x.info)
538-
for (const message of messages.data!) {
539-
draft.part[message.info.id] = message.parts
609+
draft.message[sessionID] = merged.messages
610+
for (const messageID of merged.resolved) {
611+
optimisticMessages.delete(messageID)
612+
}
613+
for (const [messageID, parts] of merged.parts) {
614+
draft.part[messageID] = parts
540615
}
541616
draft.session_diff[sessionID] = diff.data ?? []
542617
}),
Lines changed: 92 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,92 @@
1+
import { describe, expect, test } from "bun:test"
2+
import type { Message, Part } from "@opencode-ai/sdk/v2"
3+
import { mergeFetchedMessages, optimisticParts } from "@/cli/cmd/tui/context/sync-optimistic"
4+
5+
function user(id: string): Message {
6+
return {
7+
id,
8+
sessionID: "ses_test",
9+
role: "user",
10+
time: { created: 1 },
11+
agent: "build",
12+
model: { providerID: "test", modelID: "model" },
13+
}
14+
}
15+
16+
function text(messageID: string, text: string): Part {
17+
return {
18+
id: `part_${messageID}`,
19+
sessionID: "ses_test",
20+
messageID,
21+
type: "text",
22+
text,
23+
}
24+
}
25+
26+
describe("TUI optimistic prompt sync", () => {
27+
test("keeps an optimistic message while session sync has not fetched it yet", () => {
28+
const merged = mergeFetchedMessages({
29+
currentMessages: [user("msg_2")],
30+
currentParts: { msg_2: [text("msg_2", "optimistic")] },
31+
fetched: [{ info: user("msg_1"), parts: [text("msg_1", "persisted")] }],
32+
optimisticMessages: new Set(["msg_2"]),
33+
})
34+
35+
expect(merged.messages.map((message) => message.id)).toEqual(["msg_1", "msg_2"])
36+
expect(merged.parts.get("msg_1")?.map((part) => (part.type === "text" ? part.text : ""))).toEqual(["persisted"])
37+
expect(merged.resolved.has("msg_2")).toBe(false)
38+
})
39+
40+
test("preserves optimistic parts when sync fetches the message before its parts", () => {
41+
const merged = mergeFetchedMessages({
42+
currentMessages: [user("msg_1")],
43+
currentParts: { msg_1: [text("msg_1", "optimistic")] },
44+
fetched: [{ info: user("msg_1"), parts: [] }],
45+
optimisticMessages: new Set(["msg_1"]),
46+
})
47+
48+
expect(merged.messages.map((message) => message.id)).toEqual(["msg_1"])
49+
expect(merged.parts.get("msg_1")?.map((part) => (part.type === "text" ? part.text : ""))).toEqual(["optimistic"])
50+
expect(merged.resolved.has("msg_1")).toBe(false)
51+
})
52+
53+
test("replaces optimistic parts once real fetched parts arrive", () => {
54+
const merged = mergeFetchedMessages({
55+
currentMessages: [user("msg_1")],
56+
currentParts: { msg_1: [text("msg_1", "optimistic")] },
57+
fetched: [{ info: user("msg_1"), parts: [text("msg_1", "persisted")] }],
58+
optimisticMessages: new Set(["msg_1"]),
59+
})
60+
61+
expect(merged.parts.get("msg_1")?.map((part) => (part.type === "text" ? part.text : ""))).toEqual(["persisted"])
62+
expect(merged.resolved.has("msg_1")).toBe(true)
63+
})
64+
65+
test("strips file URLs from optimistic render parts", () => {
66+
const parts = optimisticParts({
67+
sessionID: "ses_test",
68+
messageID: "msg_1",
69+
parts: [
70+
{
71+
id: "part_file",
72+
type: "file",
73+
mime: "image/png",
74+
filename: "image.png",
75+
url: "data:image/png;base64,large",
76+
},
77+
],
78+
})
79+
80+
expect(parts).toEqual([
81+
{
82+
id: "part_file",
83+
sessionID: "ses_test",
84+
messageID: "msg_1",
85+
type: "file",
86+
mime: "image/png",
87+
filename: "image.png",
88+
url: "",
89+
},
90+
])
91+
})
92+
})

0 commit comments

Comments
 (0)