feat: let ACP client expose the input/output properly

[validatedev]

What does this PR do?

Fixes #10998.

Old behavior: we sent a tool_call at pending with kind: "execute". As the tool ran, updates carried the content plus a completed rawOutput. Zed relied on kind: "execute" to render the blue "run command" box, but the actual command (rawInput) only appeared after completion, so you couldn't see what was running.

New behavior: the first tool_call now reflects the tool part's actual status (e.g. in_progress when the tool is already running on first observation) and carries the full rawInput — including the resolved working directory for bash — so Zed can show the command and where it's running before output lands. Subsequent tool_call_updates fill in streaming content and the final rawOutput (stdout/stderr). kind is set to other (not execute), which removes the blue run-box styling and instead exposes rawInput/rawOutput as collapsible panels.

How did you verify your code works?

By running Zed's ACP inferface via:

    "OpenCode (ACP Dev)": {
      "type": "custom",
      "command": "bun",
      "args": [
        "run",
        "--cwd",
        "/Users/validate/Developer/personal/opencode/packages/opencode",
        "--conditions=browser",
        "./src/index.ts",
        "acp",
      ],
      "env": {},
    },

Screenshot

Old Behavior

New Behavior

[github-actions]

The following comment was made by an LLM, it may be inaccurate:

No duplicate PRs found

[rekram1-node]

Can you explain the changes, it looks like quite a bit

[validatedev]

any update @rekram1-node @adamdotdevin? I don't have any problems with this, works much better than the old structure (aligns other Zed ACP + Zed Agent interfaces)

[Copilot]

Pull request overview

This PR refactors the ACP (Agent Client Protocol) client implementation to properly expose tool input/output information to ACP clients like Zed. The main change addresses issue #10998 where command details weren't visible in the Zed UI.

Changes:

• Refactored tool call/result formatting into a centralized tool-format.ts module with structured formatting logic for different tool types
• Changed tool call emission timing from pending to running state with full rawInput (command + cwd) included upfront
• Updated tool kind from "execute" to "other" for bash/shell/terminal commands

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.

File	Description
packages/opencode/src/acp/tool-format.ts	New module containing centralized tool formatting logic with toolCallFromPart and toolResultFromPart functions
packages/opencode/src/acp/parse-command.ts	New helper module for formatting bash/shell/terminal commands with title, kind, and locations
packages/opencode/src/acp/agent.ts	Refactored to use new formatting functions; removed old toToolKind and toLocations helpers; added emittedToolCalls tracking to prevent duplicate emissions
packages/opencode/test/acp/parse-command.test.ts	Added tests for ParseCommand.format function

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[validatedev]

@adamdotdevin I really want this to be merged, and it works without any issues. Could you please review and/or merge if you have time? I've been waiting 3 months. The PR only affects the ACP part. I can fix it if you don't like any parts of the PR, and it fixes a real issue which should not be happening (and other providers' ACP clients do not have such issues).

[jiwangyihao]

I'm also seeing this in Zed ACP mode: bash tool calls show only the human-readable description (for example, Shows concise working tree status) but not the actual command being executed.

This makes permission review and debugging difficult, because users cannot tell which command is about to run without digging into logs. It looks like the same issue reported in #10998 and #14034; both were auto-closed, but the behavior is still relevant.

Could this PR be reviewed/merged, or could maintainers clarify what is blocking it?

[kian1991]

I would also push for this. This is the only thing keeping me from fully using zed + opencode. So Bump :)

[n3m0-wits]

It looks like this has been a persistent issue that keeps getting flagged and then closed as a duplicate - but then the 'duplicates' also get closed and nothing happens.

[soar]

What are we waiting for? This needs to be fixed

[validatedev]

@rekram1-node @nexxeln @thdxr waiting to be reviewed, just fyi.