Skip to content

refactor(prompt): remove prompt abort-signal plumbing#21116

Draft
kitlangton wants to merge 1 commit intodevfrom
kit/prompt-abort-cleanup
Draft

refactor(prompt): remove prompt abort-signal plumbing#21116
kitlangton wants to merge 1 commit intodevfrom
kit/prompt-abort-cleanup

Conversation

@kitlangton
Copy link
Copy Markdown
Contributor

@kitlangton kitlangton commented Apr 5, 2026

Summary

  • keep prompt title generation, synthetic reads, and shell/subtask execution on shared Effect-native services instead of prompt-local abort-signal shims
  • extract shared subtask execution into src/tool/subtask.ts so prompt and the task tool use the same child-session flow and tool gating
  • update runner and prompt regression tests to cover the new effect-native shell and subtask cancellation paths

Testing

  • bun typecheck
  • bun run test test/session/prompt-effect.test.ts test/effect/runner.test.ts test/tool/read.test.ts test/session/prompt.test.ts
  • bun run test

@kitlangton
refactor(prompt): remove prompt abort-signal plumbing
a3bf978 
Keep prompt reads, subtask execution, and shell runner wiring on shared Effect services so prompt no longer carries its own abort-signal adapters or duplicate task flow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

contributor Vouched

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kitlangton