fix(bash): compose plugin PATH instead of stomping system PATH#21774
Open
micuintus wants to merge 1 commit intoanomalyco:devfrom
Open
fix(bash): compose plugin PATH instead of stomping system PATH#21774micuintus wants to merge 1 commit intoanomalyco:devfrom
micuintus wants to merge 1 commit intoanomalyco:devfrom
Conversation
github-actions
bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
micuintus
force-pushed
the
fix/path-composition
branch
from
9576b15 to
a498f63
Compare
When plugins return PATH entries via the shell.env hook, prepend them to the existing system PATH instead of replacing it entirely. This preserves standard paths like /usr/bin.
micuintus
force-pushed
the
fix/path-composition
branch
from
a498f63 to
810fba1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #21768
Type of change
What does this PR do?
Fixes PATH handling in
shellEnv(). When plugins returned PATH entries via theshell.envhook, the spread...extra.envstomped the system PATH entirely — commands likelsandgitbroke because/usr/binwas gone.Now plugin PATH entries are extracted before the spread, then prepended to
process.env.PATHso both plugin binaries and system commands work.How did you verify your code works?
bun turbo typecheckpassesScreenshots / recordings
No UI changes.
Checklist
Part of the plugin primitives work split from #21687 (tracking issue #20018).