test(project): rescue non-Hono InstanceBootstrap boundary tests#26453
Merged
Conversation
kitlangton
force-pushed
the
kit/httpapi-test-script-effect-mode
branch
from
3986e17 to
6b13e18
Compare
kitlangton
force-pushed
the
kit/test-rescue-instance-bootstrap
branch
from
bc957f9 to
02e21fc
Compare
kitlangton
force-pushed
the
kit/httpapi-test-script-effect-mode
branch
from
6b13e18 to
dfb49e5
Compare
kitlangton
force-pushed
the
kit/test-rescue-instance-bootstrap
branch
from
02e21fc to
800992e
Compare
kitlangton
force-pushed
the
kit/httpapi-test-script-effect-mode
branch
from
dfb49e5 to
1df6d83
Compare
kitlangton
force-pushed
the
kit/test-rescue-instance-bootstrap
branch
from
800992e to
1df6d83
Compare
kitlangton
force-pushed
the
kit/httpapi-test-script-effect-mode
branch
from
31eded7 to
81681f2
Compare
kitlangton
force-pushed
the
kit/test-rescue-instance-bootstrap
branch
from
a0dbe07 to
5e84331
Compare
kitlangton
force-pushed
the
kit/httpapi-test-script-effect-mode
branch
from
81681f2 to
a605023
Compare
kitlangton
force-pushed
the
kit/test-rescue-instance-bootstrap
branch
from
5e84331 to
d1d42db
Compare
kitlangton
force-pushed
the
kit/httpapi-test-script-effect-mode
branch
from
a605023 to
897eb7f
Compare
kitlangton
force-pushed
the
kit/test-rescue-instance-bootstrap
branch
from
d1d42db to
20e338c
Compare
kitlangton
force-pushed
the
kit/httpapi-test-script-effect-mode
branch
from
897eb7f to
940633e
Compare
kitlangton
force-pushed
the
kit/test-rescue-instance-bootstrap
branch
from
20e338c to
b7425e3
Compare
kitlangton
force-pushed
the
kit/httpapi-test-script-effect-mode
branch
from
940633e to
d086513
Compare
kitlangton
force-pushed
the
kit/test-rescue-instance-bootstrap
branch
from
b7425e3 to
d26a17b
Compare
kitlangton
changed the base branch from
kit/httpapi-test-script-effect-mode
to
dev
The existing test/project/instance-bootstrap-regression.test.ts covers four boundaries: WithInstance.provide, the CLI bootstrap, the legacy Hono InstanceMiddleware, and InstanceRuntime.reloadInstance. The Hono deletion PR (#25667) drops the entire file because the Hono variant goes away, taking the three backend-agnostic boundary checks with it. Move the three surviving boundary checks into a new instance-bootstrap.test.ts so the InstanceBootstrap-runs-at-boundary invariant stays covered after Hono is deleted. The original file can remain in place until #25667 lands; once the deletion lands, only this file remains.
kitlangton
force-pushed
the
kit/test-rescue-instance-bootstrap
branch
from
d26a17b to
5e288fa
Compare
katosun2
pushed a commit
to katosun2/opencode
that referenced
this pull request
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan