fix(app): display i18n-translated title in slash command popover#26824
Closed
kagura-agent wants to merge 2 commits into
Closed
fix(app): display i18n-translated title in slash command popover#26824kagura-agent wants to merge 2 commits into
kagura-agent wants to merge 2 commits into
Conversation
The slash command popover rendered only the English trigger text (e.g. '/share', '/undo') as the primary label. The translated title field, which is already properly internationalized across all supported locales, was never displayed. Show the translated title as the primary label and keep the trigger as a subtle secondary hint so users can still discover the actual command text. Fixes anomalyco#26778
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Contributor
Author
|
Hi 👋 friendly ping — this has been open for a week. Happy to adjust anything if needed! |
Contributor
Author
|
Hi — friendly ping on this PR. Let me know if there's any feedback or changes needed. 🙂 |
Contributor
Author
|
Closing this PR — it's been open for 11 days with two pings and no response. Happy to reopen if there's interest. Thanks! 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #26778
Type of change
What does this PR do?
The slash command popover in
slash-popover.tsxrenders/{cmd.trigger}as the primary label — this is always the English command word (e.g.share,undo). Thecmd.titlefield, which is properly internationalized vialanguage.t()across all supported locales, is never displayed.This change shows
cmd.titleas the primary bold label and keeps/{cmd.trigger}as a smaller subtle hint beside it. This matches the pattern the command palette (Ctrl+K) already uses indialog-select-file.tsx.For English users the visual change is minimal (e.g.
Share Session /sharevs/share). For non-English locales the translated name is now visible (e.g.分享会话 /share).How did you verify your code works?
tsgo -bon@opencode-ai/app, all 14 packages pass except unrelated upstreamphoton-nodemodule missing inopencodepackage)titlefield is already defined in theSlashCommandinterface and populated by command definitions — this change only renders itScreenshots / recordings
N/A (no local desktop build available — change is a 2-line template swap in the popover JSX)
Checklist