Skip to content

fix(app): use keyed Show for project in layout#26985

Merged
Brendonovich merged 3 commits into
devfrom
brendan/layout-keyed-project-cleanup
May 12, 2026
Merged

fix(app): use keyed Show for project in layout#26985
Brendonovich merged 3 commits into
devfrom
brendan/layout-keyed-project-cleanup

Conversation

@Brendonovich
Copy link
Copy Markdown
Member

Summary

  • Adds the keyed prop to the Show component wrapping the current project in layout.tsx
  • This lets us receive the resolved project directly instead of a Solid signal accessor
  • Removes redundant const item = project(); if (!item) return guards throughout the render callback
  • Passes project directly to child components and handlers instead of calling project()

Type safety improvement: no more optional chaining / null checks on a value that is guaranteed to exist inside the Show body.

@Brendonovich Brendonovich merged commit 8713748 into dev May 12, 2026
8 checks passed
@Brendonovich Brendonovich deleted the brendan/layout-keyed-project-cleanup branch May 12, 2026 02:39
leohenon pushed a commit to leohenon/opencode-vim that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant