fix(core): prevent auto-updating session timestamps on metadata changes#28430
Open
ariane-emory wants to merge 10 commits into
Open
fix(core): prevent auto-updating session timestamps on metadata changes#28430ariane-emory wants to merge 10 commits into
ariane-emory wants to merge 10 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #23354
Type of change
What does this PR do?
Prevents session timestamps from being updated on metadata-only changes, so as to, for example, prevent sessions from jumping unexpectedly in the session_list 's ordering when they are renamed.
This is a recreation of this PR that was mistakenly closed by the auto cleanup routine: #28429
How did you verify your code works?
bun test,bun typecheck, manual testing.Screenshots / recordings
N/A
Checklist