refactor(httpapi): describe bodyless global upgrade payload#29264
Merged
kitlangton merged 1 commit intoMay 25, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /global/upgradeas accepting eitherGlobalUpgradeInputorHttpApiSchema.NoContent.Context
/global/upgradealready treats an absent request body as{}and uses that to select the latest version. Its HttpApi declaration described only the object body, so this aligns the declared contract with existing behavior.This is an internal contract correction and regression-coverage improvement, not a user-facing runtime bug fix: bodyless requests already succeeded before this change.
HttpApiSchema.NoContentis the intended HttpApi representation for that supported bodyless request shape.Verification
bun prettier --write src/server/routes/instance/httpapi/groups/global.ts test/server/httpapi-global.test.tsbun oxlint packages/opencode/src/server/routes/instance/httpapi/groups/global.ts packages/opencode/test/server/httpapi-global.test.tsbun typecheckfrompackages/opencodebun run test -- test/server/httpapi-global.test.tsfrompackages/opencode./packages/sdk/js/script/build.ts(no generated SDK changes)bun turbo typecheckpassed across the workspace