fix(web): persist docs English locale selection#29351
Open
YOMXXX wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29326
Type of change
What does this PR do?
Fixes the docs language picker path where selecting English from a localized docs page navigates to the unprefixed default-locale URL but did not update
oc_locale. The middleware now treats unprefixed docs HTML navigations as an English selection and persistsoc_locale=en, while keeping localized paths and non-HTML asset requests unchanged.How did you verify your code works?
cd packages/web && PATH="$HOME/.bun/bin:$PATH" bun test src/middleware-locale.test.tsgit diff --checkPATH="$HOME/.bun/bin:$PATH" .husky/pre-pushcd packages/web && PATH="$HOME/.bun/bin:$PATH" bun run astro check(attempted; exits with existing unrelated diagnostics insrc/components/Share.tsx,src/components/share/part.tsx, andsrc/pages/s/[id].astro)Screenshots / recordings
N/A (middleware-only change).
Checklist