feat(session): respect explicit session ids in session create with duplicate detection#29358
Open
sjawhar wants to merge 1 commit into
Open
feat(session): respect explicit session ids in session create with duplicate detection#29358sjawhar wants to merge 1 commit into
sjawhar wants to merge 1 commit into
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #17344
Re-submission of #21571 (closed by automated cleanup), rebased onto current dev. The previous PR could not be reopened because the branch has been force-pushed since closure.
Type of change
What does this PR do?
Allows callers to specify an explicit session ID at create time (matching the request in #17344), with proper duplicate detection: returns a
DuplicateIDError(HTTP 409 via the API) instead of silently overwriting or generating a new ID.How did you verify your code works?
test/session/session.test.tscovers the custom-ID round-trip and duplicate detection paths. SDK regenerated to expose the new error type.bun typecheckpasses.Checklist