fix: print empty session json#30148
Closed
he-yufeng wants to merge 1 commit into
Closed
Conversation
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #30100
Type of change
What does this PR do?
session list --format jsonprinted empty stdout when no sessions existed, which makes the command invalid for scripts expecting JSON. This keeps the output machine-readable by returning[]for the empty list case and adds a CLI smoke regression.How did you verify your code works?
bun --cwd packages\opencode test test\cli\smokes\read-only.test.ts -t "session list json"bun --cwd packages\opencode typecheckbunx prettier --check packages\opencode\src\cli\cmd\session.ts packages\opencode\test\cli\smokes\read-only.test.tsbunx oxlint packages\opencode\src\cli\cmd\session.ts packages\opencode\test\cli\smokes\read-only.test.ts(existing warning only, no errors)git diff --checkScreenshots / recordings
N/A; this is CLI JSON output behavior.
Checklist