fix(opencode): populate agent/model on task-tool subagent child sessions#30741
Closed
FlorianOtel wants to merge 2 commits into
Closed
fix(opencode): populate agent/model on task-tool subagent child sessions#30741FlorianOtel wants to merge 2 commits into
FlorianOtel wants to merge 2 commits into
Conversation
After ddc30cd made agent and model explicit inputs to Session.create(), the task.ts call site was never updated to pass them. The model value is already derived for the prompt invocation but sits after the create call. Child sessions ended up with NULL agent and model in the DB, breaking attribution for downstream consumers (telemetry, status-line, etc.). Hoist the parent-message fetch and model derivation above sessions.create() so the values are available at row-creation time, then pass agent: next.name and model (converted to Session.Model's { id, providerID } shape) explicitly. The prompt-invocation model keeps its own { modelID, providerID } variable. Adds regression tests (Tests A/B/C) in test/tool/task.test.ts. Fixes regression introduced by: ddc30cd feat(core): add session metadata support (anomalyco#23068)
This was referenced Jun 4, 2026
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After ddc30cd made agent and model explicit inputs to Session.create(), the task.ts call site was never updated to pass them. The model value is already derived for the prompt invocation but sits after the create call. Child sessions ended up with NULL agent and model in the DB, breaking attribution for downstream consumers (telemetry, status-line, etc.).
Hoist the parent-message fetch and model derivation above sessions.create() so the values are available at row-creation time, then pass agent: next.name and model (converted to Session.Model's { id, providerID } shape) explicitly. The prompt-invocation model keeps its own { modelID, providerID } variable.
Adds regression tests (Tests A/B/C) in test/tool/task.test.ts.
Fixes regression introduced by: ddc30cd feat(core): add session metadata support (#23068)
Issue for this PR
Closes #30734
Type of change
What does this PR do?
After ddc30cd made agent and model explicit inputs to Session.create(),
the task.ts call site was never updated to pass them. The model value is
already derived for the prompt invocation but sits after the create call.
Child sessions ended up with NULL agent and model in the DB, breaking
attribution for downstream consumers (telemetry, status-line, etc.).
Hoist the parent-message fetch and model derivation above sessions.create()
so the values are available at row-creation time, then pass agent: next.name
and model (converted to Session.Model's { id, providerID } shape) explicitly.
The prompt-invocation model keeps its own { modelID, providerID } variable.
Adds regression tests (Tests A/B/C) in test/tool/task.test.ts.
Fixes regression introduced by: ddc30cd feat(core): add session metadata support (#23068)
How did you verify your code works?
Local build + test + local deployment
Screenshots / recordings
N/A
Checklist