fix(core): include last 2KB in sampledChecksum window#33099
Open
Robin1987China wants to merge 1 commit into
Open
fix(core): include last 2KB in sampledChecksum window#33099Robin1987China wants to merge 1 commit into
Robin1987China wants to merge 1 commit into
Conversation
The last sampling point was content.length - size, which after centering and clamping produced a window ending at content.length - 2048. The final ~2KB was never hashed, so edits to the end of large files did not change the cache key and the UI showed stale content. Closes anomalyco#33098
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #33098
Type of change
What does this PR do?
sampledChecksum()inpackages/core/src/util/encode.tsusedcontent.length - sizeas the last sampling point. After centering and clamping, the last window covered[content.length - 6144, content.length - 2048]— the final ~2KB was never hashed. Since this function is used as a cache key for file viewers (file.tsx,file-tabs.tsx), edits to the end of large files (>500KB) went undetected and the UI showed stale content.This PR changes the last point to
content.lengthso the clamped window ends exactly atcontent.length, covering the final bytes.How did you verify your code works?
bun turbo typecheck: all 29 packages passChecklist