fix(core): support OTLP protobuf protocol#33100
Open
iw-an wants to merge 3 commits into
Open
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #33101
Type of change
What does this PR do?
Adds support for OTLP HTTP protobuf export configuration.
Previously observability always used JSON serialization for Effect OTLP logs and the JSON trace exporter. This meant
OTEL_EXPORTER_OTLP_PROTOCOL=http/protobufand the signal-specific protocol env vars were not honored.This PR reads:
OTEL_EXPORTER_OTLP_PROTOCOLOTEL_EXPORTER_OTLP_TRACES_PROTOCOLOTEL_EXPORTER_OTLP_LOGS_PROTOCOLLogs now use the matching Effect
OtlpSerializationlayer, and traces now choose the JSON or protobuf OpenTelemetry trace exporter based on the trace protocol. Workspace startup also passes these OTEL protocol env vars through so child workspaces keep the same observability configuration.Unsupported protocol values fall back to
http/json.How did you verify your code works?
Ran from
packages/core:bun test test/effect/observability.test.tsbun typecheckAlso ran:
git diff --checkScreenshots / recordings
N/A, not a UI change.
Checklist