Skip to content

fix(core): support OTLP protobuf protocol#33100

Open
iw-an wants to merge 3 commits into
anomalyco:devfrom
iw-an:ij/otel-protobuf
Open

fix(core): support OTLP protobuf protocol#33100
iw-an wants to merge 3 commits into
anomalyco:devfrom
iw-an:ij/otel-protobuf

Conversation

@iw-an

@iw-an iw-an commented Jun 20, 2026

Copy link
Copy Markdown

Issue for this PR

Closes #33101

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Adds support for OTLP HTTP protobuf export configuration.

Previously observability always used JSON serialization for Effect OTLP logs and the JSON trace exporter. This meant OTEL_EXPORTER_OTLP_PROTOCOL=http/protobuf and the signal-specific protocol env vars were not honored.

This PR reads:

  • OTEL_EXPORTER_OTLP_PROTOCOL
  • OTEL_EXPORTER_OTLP_TRACES_PROTOCOL
  • OTEL_EXPORTER_OTLP_LOGS_PROTOCOL

Logs now use the matching Effect OtlpSerialization layer, and traces now choose the JSON or protobuf OpenTelemetry trace exporter based on the trace protocol. Workspace startup also passes these OTEL protocol env vars through so child workspaces keep the same observability configuration.

Unsupported protocol values fall back to http/json.

How did you verify your code works?

Ran from packages/core:

  • bun test test/effect/observability.test.ts
  • bun typecheck

Also ran:

  • git diff --check

Screenshots / recordings

N/A, not a UI change.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. needs:issue labels Jun 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions github-actions Bot removed needs:issue needs:compliance This means the issue will auto-close after 2 hours. labels Jun 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OTLP protobuf protocol configuration is ignored

1 participant