fix(desktop): prevent large diff timeline hangs#33122
Open
ZhongYanZhiShi wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #33106
Type of change
What does this PR do?
Large session summaries can include thousands of unique file diffs. The timeline row builder was deduplicating those diffs by scanning the already collected result for each item, which turns that path quadratic and can block the desktop renderer.
This changes diff summary deduplication to a Set-backed reverse scan, preserving the existing behavior of showing the last diff for each file in original display order. It also makes desktop recovery logging safe when Electron has already destroyed a BrowserWindow or WebContents, so recovery logs do not throw
Object has been destroyed.How did you verify your code works?
bun test ./src/main/window-state.test.tsgit diff --checkbun turbo typecheckvia the pre-push hookScreenshots / recordings
Not a visual UI change.
Checklist